Merge pull request #5 from genedna/main

Add Windows crates and refacotring build.bzl

Author: benjamin-747

BUCK

@@ -6,6 +6,25 @@ cargo.rust_binary(
     srcs = glob(["src/**/*.rs"]),
     crate_root = "src/main.rs",
     deps = [
+        # ---
+        "//third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0:deno-x86_64-pc-windows-msvc",
+        "//third-party/rust/crates/windows_x86_64_msvc/0.53.0:windows_x86_64_msvc",
+        "//third-party/rust/crates/windows_x86_64_gnullvm/0.53.0:windows_x86_64_gnullvm",
+        "//third-party/rust/crates/windows_x86_64_gnu/0.53.0:windows_x86_64_gnu",
+        "//third-party/rust/crates/windows_i686_msvc/0.53.0:windows_i686_msvc",
+        "//third-party/rust/crates/windows_i686_gnullvm/0.53.0:windows_i686_gnullvm",
+        "//third-party/rust/crates/windows_i686_gnu/0.53.0:windows_i686_gnu",
+        "//third-party/rust/crates/windows_aarch64_msvc/0.53.0:windows_aarch64_msvc",
+        "//third-party/rust/crates/windows_aarch64_gnullvm/0.53.0:windows_aarch64_gnullvm",
+        "//third-party/rust/crates/winapi-i686-pc-windows-gnu/0.4.0:winapi-i686-pc-windows-gnu",
+        "//third-party/rust/crates/winapi-x86_64-pc-windows-gnu/0.4.0:winapi-x86_64-pc-windows-gnu",
+        "//third-party/rust/crates/winapi/0.3.9:winapi", # --config rust.features=everything,impl-debug,impl-default --config rust.target=i686-pc-windows-gnu
+        # ---
+
+        # rand_core
+        "//third-party/rust/crates/rand_core/0.3.1:rand_core",
+        "//third-party/rust/crates/rand_core/0.4.0:rand_core",
+
         # autocfg
         "//third-party/rust/crates/autocfg/1.4.0:autocfg",
 
@@ -76,15 +95,15 @@ cargo.rust_binary(
         "//third-party/rust/crates/static_assertions/1.1.0:static_assertions",
 
         # syn
-        # "//third-party/rust/crates/syn/2.0.81",
+        # "//third-party/rust/crates/syn/2.0.81:syn",
         # ---
 
         # Serde
-        # "//third-party/rust/crates/serde/1.0.60:serde",
+        #"//third-party/rust/crates/serde/1.0.60:serde",
         # ---
 
         # Serde_derive
-        # "//third-party/rust/crates/serde_derive/1.0.218:serde_derive",
+        #"//third-party/rust/crates/serde_derive/1.0.218:serde_derive",
         # ---
 
         # foreign-types

third-party/README.md

@@ -80,13 +80,13 @@ rm -rf .devcontainer
 For now, I am trying to generate `BUCK` with `Cargo.toml` with Claude, and the promote words in Chinese:
 
 
-编写附件 Cargo.toml 对应功能的 BUCK 文件，满足 Buck2 编译的需求，要求包括：
+编写附件 Cargo.toml 和 build.rs 对应功能的 BUCK 文件，满足 Buck2 编译的需求，要求包括：
 
 * BUCK 文件中的注释使用英文；
 * 交互过程使用中文；
 * 使用 `load("@prelude//toolchains:rust.bzl", "system_rust_toolchain")`;
 * BUCK 文件中没有 `version` 和 `licenses` 字段；
-* BUCK 文件中 `edition` 字段固定使用 `2021`；
+* BUCK 文件中 `edition` 字段固定使用 Cargo.toml 中的 `edition` ；
 * 如果有依赖存在，请使用 `//third-party/rust/crates/<crate_name>/<crate_version>:<crate_name>` 来替换；
 * 如果有 Feature, 采用通过 `--config` 传入构建参数，加入以下函数设计：
 ```

third-party/rust/crates/anstyle/1.0.10/BUCK

@@ -1,5 +1,5 @@
 load("@prelude//toolchains:rust.bzl", "system_rust_toolchain")
-load("//build.bzl", "get_rust_features")
+load("//third-party/rust/crates/anstyle/1.0.10:build.bzl", "get_rust_features")
 
 rust_library(
     name = "anstyle",

third-party/rust/crates/anstyle/1.0.10/build.bzl

@@ -0,0 +1,13 @@
+"""Build configuration module for zstd-sys crate.
+
+This module provides functionality for configuring Rust features and standard library
+support for the zstd-sys crate build process. It handles feature flag management and
+platform-specific configurations.
+"""
+
+def get_rust_features():
+    features_config = read_config("rust", "features", "")
+    
+    if features_config == "":
+        return ["legacy", "zdict_builder"]  # Default features
+    return [f.strip() for f in features_config.split(",") if f.strip()]

third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0/BUCK

@@ -0,0 +1,19 @@
+load("@prelude//toolchains:rust.bzl", "system_rust_toolchain")
+load("//third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0:build.bzl", "get_rustc_flags")
+
+# This rust_library is for deno-x86_64-pc-windows-msvc binaries
+# It implements the functionality from the original Cargo.toml and build.rs
+rust_library(
+    name = "deno-x86_64-pc-windows-msvc",
+    # Using fixed edition as per requirements
+    # Note: original Cargo.toml doesn't specify edition, defaulting to 2015
+    edition = "2021",
+    srcs = glob(["src/**/*.rs"]),
+    crate_root = "src/lib.rs",
+    features = [],
+    # Conditionally add rustc flags based on target triple
+    rustc_flags = get_rustc_flags(),
+    env = {},
+    deps = [],
+    visibility = ["PUBLIC"],
+)

third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0/Cargo.toml

@@ -0,0 +1,21 @@
+# THIS FILE IS AUTOMATICALLY GENERATED BY CARGO
+#
+# When uploading crates to the registry Cargo will automatically
+# "normalize" Cargo.toml files for maximal compatibility
+# with all versions of Cargo and also rewrite `path` dependencies
+# to registry (e.g., crates.io) dependencies
+#
+# If you believe there's an error in this file please file an
+# issue against the rust-lang/cargo repository. If you're
+# editing this file be aware that the upstream Cargo.toml
+# will likely look very different (and much more reasonable)
+
+[package]
+name = "deno-x86_64-pc-windows-msvc"
+version = "0.23.0"
+authors = ["The deno authors <bertbelder@nodejs.org>"]
+build = "build.rs"
+include = ["src/*", "lib/*", "Cargo.toml", "build.rs"]
+description = "Binary dependencies for the 'deno' crate"
+license = "MIT"
+repository = "https://github.com/denoland/deno"

third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0/Cargo.toml.orig

@@ -0,0 +1,17 @@
+def get_rustc_flags():
+    """
+    Determine rustc flags based on target platform.
+    
+    This mimics the build.rs logic which only sets the library search path
+    when the target is x86_64-pc-windows-msvc.
+    """
+    # Get target platform from config
+    target = read_config("rust", "target", "")
+    
+    # Only add link search path for x86_64-pc-windows-msvc target
+    if target == "x86_64-pc-windows-msvc":
+        return [
+            "-L",
+            "native=lib",
+        ]
+    return []

third-party/rust/crates/deno-x86_64-pc-windows-msvc/0.23.0/build.bzl

@@ -0,0 +1,15 @@
+
+fn main() {
+  use std::env::var;
+  use std::path::Path;
+  if var("TARGET")
+    .map(|target| target == "x86_64-pc-windows-msvc")
+    .unwrap_or(false)
+  {
+    let dir = var("CARGO_MANIFEST_DIR").unwrap();
+    println!(
+      "cargo:rustc-link-search=native={}",
+      Path::new(&dir).join("lib").display()
+    );
+  }
+}