Don't unregister and register message event listener if not needed

piranna · Minishlink · commit b74b31ec8885 · 2017-10-15T12:12:37.000+02:00
diff --git a/src/index.js b/src/index.js
@@ -34,9 +34,13 @@ export default class extends Component {
   }
 
   componentWillReceiveProps(nextProps) {
+    const {onMessage} = nextProps
+
+    if(this.props.onMessage && onMessage) return
+
     componentWillUnmount()
 
-    if (nextProps.onMessage) {
+    if (onMessage) {
       window.addEventListener('message', this.onMessage, true);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,13 @@ export default class extends Component {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`componentWillReceiveProps(nextProps) {`
	`37`	`+ const {onMessage} = nextProps`
	`38`	`+`
	`39`	`+ if(this.props.onMessage && onMessage) return`
	`40`	`+`
`37`	`41`	`componentWillUnmount()`
`38`	`42`
`39`		`- if (nextProps.onMessage) {`
	`43`	`+ if (onMessage) {`
`40`	`44`	`window.addEventListener('message', this.onMessage, true);`
`41`	`45`	`}`
`42`	`46`	`}`