Merge pull request #21 from reactphp-parallel/add-tests-for-notify-and-destruct

Add tests for Notify and Destruct messages

Author: WyriHaximus

Makefile

@@ -40,7 +40,7 @@ psalm: ## Run static analysis (Psalm)
 	$(DOCKER_RUN) vendor/bin/psalm --threads=$(shell nproc) --shepherd --stats
 
 unit: ## Run tests
-	$(DOCKER_RUN) vendor/bin/phpunit --colors=always -c phpunit.xml.dist --coverage-text --coverage-html covHtml --coverage-clover ./build/logs/clover.xml --filter metricsDestructionTesting
+	$(DOCKER_RUN) vendor/bin/phpunit --colors=always -c phpunit.xml.dist --coverage-text --coverage-html covHtml --coverage-clover ./build/logs/clover.xml
 
 unit-ci: unit
 	if [ -f ./build/logs/clover.xml ]; then wget https://scrutinizer-ci.com/ocular.phar && sleep 3 && php ocular.phar code-coverage:upload --format=php-clover ./build/logs/clover.xml; fi

src/AbstractGeneratedProxy.php

@@ -47,12 +47,11 @@ final protected function proxyCallToMainThread(string $method, array $args)
     /**
      * @param mixed[] $args
      */
-    final protected function proxyNotifyMainThread(string $interface, string $method, array $args): void
+    final protected function proxyNotifyMainThread(string $method, array $args): void
     {
         $this->out->send(new Notify(
             $this->hash,
             spl_object_hash($this),
-            $interface,
             $method,
             $args,
         ));

src/Message/Notify.php

@@ -8,7 +8,6 @@ final class Notify
 {
     private string $hash;
     private string $objectHash;
-    private string $interface;
 
     private string $method;
 
@@ -18,11 +17,10 @@ final class Notify
     /**
      * @param mixed[] $args
      */
-    public function __construct(string $hash, string $objectHash, string $interface, string $method, array $args)
+    public function __construct(string $hash, string $objectHash, string $method, array $args)
     {
         $this->hash       = $hash;
         $this->objectHash = $objectHash;
-        $this->interface  = $interface;
         $this->method     = $method;
         $this->args       = $args;
     }
@@ -37,11 +35,6 @@ public function objectHash(): string
         return $this->objectHash;
     }
 
-    public function interface(): string
-    {
-        return $this->interface;
-    }
-
     public function method(): string
     {
         return $this->method;

tests/Message/DestructTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ReactParallel\Tests\ObjectProxy\Message;
+
+use ReactParallel\ObjectProxy\Message\Destruct;
+use WyriHaximus\AsyncTestUtilities\AsyncTestCase;
+
+use function bin2hex;
+use function random_bytes;
+
+final class DestructTest extends AsyncTestCase
+{
+    /**
+     * @test
+     */
+    public function getters(): void
+    {
+        $hash       = bin2hex(random_bytes(1024));
+        $objectHash = bin2hex(random_bytes(1024));
+
+        $call = new Destruct($hash, $objectHash);
+
+        self::assertSame($hash, $call->hash());
+        self::assertSame($objectHash, $call->objectHash());
+    }
+}

tests/Message/NotifyTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace ReactParallel\Tests\ObjectProxy\Message;
+
+use ReactParallel\ObjectProxy\Message\Notify;
+use WyriHaximus\AsyncTestUtilities\AsyncTestCase;
+
+use function bin2hex;
+use function random_bytes;
+use function time;
+
+final class NotifyTest extends AsyncTestCase
+{
+    /**
+     * @test
+     */
+    public function getters(): void
+    {
+        $hash       = bin2hex(random_bytes(1024));
+        $objectHash = bin2hex(random_bytes(1024));
+        $method     = 'hammer';
+        $args       = [time()];
+
+        $call = new Notify($hash, $objectHash, $method, $args);
+
+        self::assertSame($hash, $call->hash());
+        self::assertSame($objectHash, $call->objectHash());
+        self::assertSame($method, $call->method());
+        self::assertSame($args, $call->args());
+    }
+}