Merge pull request #34 from reactphp-parallel/proxy-share

Turn lock into a sharing mechanism

Author: WyriHaximus

infection.json.dist

@@ -17,22 +17,22 @@
         "@default": true,
         "ArrayItemRemoval": {
             "ignore": [
-                "ReactParallel\\ObjectProxy\\Proxy::setUpHandlers::122"
+                "ReactParallel\\ObjectProxy\\Proxy::setUpHandlers::132"
             ]
         },
         "InstanceOf_": {
             "ignore": [
-                "ReactParallel\\ObjectProxy\\Proxy::setUpHandlers::122"
+                "ReactParallel\\ObjectProxy\\Proxy::setUpHandlers::132"
             ]
         },
         "MethodCallRemoval": {
             "ignore": [
-                "ReactParallel\\ObjectProxy\\Proxy::__destruct::117"
+                "ReactParallel\\ObjectProxy\\Proxy::__destruct::127"
             ]
         },
         "PublicVisibility": {
             "ignore": [
-                "ReactParallel\\ObjectProxy\\Proxy::__destruct::109",
+                "ReactParallel\\ObjectProxy\\Proxy::__destruct::119",
                 "ReactParallel\\ObjectProxy\\NonExistentInterface::interface::22",
                 "ReactParallel\\ObjectProxy\\Message\\Parcel::notify::27",
                 "ReactParallel\\ObjectProxy\\Proxy\\Instance::interface::39"

src/Proxy.php

@@ -41,6 +41,9 @@ final class Proxy extends ProxyList
     /** @var array<string, Instance> */
     private array $instances = [];
 
+    /** @var array<string, string> */
+    private array $shared = [];
+
     /** @var array<string, string|false> */
     private array $detectedClasses = [];
 
@@ -89,20 +92,27 @@ public function has(string $interface): bool
         return array_key_exists($interface, self::KNOWN_INTERFACE);
     }
 
-    public function create(object $object, string $interface, bool $locked = false): object
+    public function create(object $object, string $interface, bool $share = false): object
     {
         if ($this->has($interface) === self::HASNT_PROXYABLE_INTERFACE) {
             throw NonExistentInterface::create($interface);
         }
 
+        if (array_key_exists($interface, $this->shared)) {
+            return $this->instances[$this->shared[$interface]];
+        }
+
         /**
          * @psalm-suppress EmptyArrayAccess
          */
         $class    = self::KNOWN_INTERFACE[$interface];
-        $instance = new Instance($object, $interface, $locked);
+        $instance = new Instance($object, $interface, $share);
         $hash     = $instance->class() . '___' . spl_object_hash($object);
 
         $this->instances[$hash] = $instance;
+        if ($share) {
+            $this->shared[$interface] = $hash;
+        }
 
         if ($this->counterCreate instanceof Counters) {
             $this->counterCreate->counter(new Label('class', $this->instances[$hash]->class()), new Label('interface', $interface))->incr();