Subscriptions: fix canceling subscription (#12224)

ref
https://read-the-docs.sentry.io/issues/6642606768/?project=161479&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

Author: stsewd

readthedocs/payments/tests/__init__.py

@@ -0,0 +1,22 @@
+import requests_mock
+from django.test import TestCase
+
+from readthedocs.payments.tests.utils import PaymentMixin
+from readthedocs.payments.utils import cancel_subscription
+
+
+class TestUtils(PaymentMixin, TestCase):
+
+    @requests_mock.Mocker(kw="mock_request")
+    def test_cancel_subscription(self, mock_request):
+        subscription_id = "sub_1234567890"
+        delete_request = mock_request.delete(
+            f"https://api.stripe.com/v1/subscriptions/{subscription_id}",
+            json={
+                "id": subscription_id,
+                "object": "subscription",
+                "status": "canceled",
+            },
+        )
+        cancel_subscription(subscription_id)
+        assert delete_request.called

readthedocs/payments/tests/test_utils.py

@@ -50,7 +50,7 @@ def cancel_subscription(subscription_id):
             "Canceling stripe subscription.",
             stripe_subscription=subscription_id,
         )
-        return stripe_client.subscriptions.delete(subscription_id)
+        return stripe_client.subscriptions.cancel(subscription_id)
     except stripe.error.StripeError:
         log.exception(
             "Subscription not cancelled. Subscription not found on Stripe. ",