add known return mixed on get (#7425)

TomasVotruba · actions-user · web-flow · commit 0e2401b63e33 · 2025-10-05T13:03:49.000+02:00
* add known return mixed on get

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action &lt;actions@github.com&gt;
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Fixture/get_and_set.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector/Fixture/get_and_set.php.inc
@@ -21,7 +21,7 @@ namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodT
 
 final class GetAndSet
 {
-    public function __get(string $method)
+    public function __get(string $method): mixed
     {
     }
 
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector.php b/rules/TypeDeclaration/Rector/ClassMethod/KnownMagicClassMethodTypeRector.php
@@ -110,6 +110,11 @@ public function refactor(Node $node): ?Node
                 }
             }
 
+            if ($this->isName($classMethod, MethodName::__GET) && $this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::MIXED_TYPE) && ! $classMethod->returnType instanceof Node) {
+                $classMethod->returnType = new Identifier('mixed');
+                $hasChanged = true;
+            }
+
             if ($this->isName($classMethod, MethodName::__SET) && $this->phpVersionProvider->isAtLeastPhpVersion(
                 PhpVersionFeature::MIXED_TYPE
             )) {

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\KnownMagicClassMethodT`
`21`	`21`
`22`	`22`	`final class GetAndSet`
`23`	`23`	`{`
`24`		`- public function __get(string $method)`
	`24`	`+ public function __get(string $method): mixed`
`25`	`25`	`{`
`26`	`26`	`}`
`27`	`27`
Original file line number	Diff line number	Diff line change
`@@ -110,6 +110,11 @@ public function refactor(Node $node): ?Node`
`110`	`110`	`}`
`111`	`111`	`}`
`112`	`112`
	`113`	`+ if ($this->isName($classMethod, MethodName::__GET) && $this->phpVersionProvider->isAtLeastPhpVersion(PhpVersionFeature::MIXED_TYPE) && ! $classMethod->returnType instanceof Node) {`
	`114`	`+ $classMethod->returnType = new Identifier('mixed');`
	`115`	`+ $hasChanged = true;`
	`116`	`+ }`
	`117`	`+`
`113`	`118`	`if ($this->isName($classMethod, MethodName::__SET) && $this->phpVersionProvider->isAtLeastPhpVersion(`
`114`	`119`	`PhpVersionFeature::MIXED_TYPE`
`115`	`120`	`)) {`