fix: EnumCaseToPascalCaseRector bugs

Author: calebdw

rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Fixture/case_on_self.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Fixture;
+
+enum CaseOnSelf
+{
+    case PENDING;
+
+    function isPending(): bool
+    {
+        return $this === self::PENDING;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Fixture;
+
+enum CaseOnSelf
+{
+    case Pending;
+
+    function isPending(): bool
+    {
+        return $this === self::Pending;
+    }
+}
+
+?>

rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Fixture/skip_enum_const.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Fixture;
+
+enum SkipEnumConst
+{
+    const FOO = 'foo';
+
+    case Pending;
+
+    function test(): void
+    {
+        echo self::FOO;
+    }
+}

rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Fixture/skip_enum_usage_in_other_package.php.inc

@@ -2,7 +2,7 @@
 
 namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Fixture;
 
-use Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Source\StatusEnum;
+use Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Source\Autoload\StatusEnum;
 
 class SkipEnumUsageInOtherPackage {
     public function isValid(StatusEnum $status): bool {

…ToPascalCaseRector/Source/StatusEnum.php …aseRector/Source/Autoload/StatusEnum.phprules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Source/StatusEnum.php renamed to rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Source/Autoload/StatusEnum.php rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Source/StatusEnum.php renamed to rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/Source/Autoload/StatusEnum.php

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Source;
+namespace Rector\Tests\CodingStyle\Rector\Enum_\EnumCaseToPascalCaseRector\Source\Autoload;
 
 enum StatusEnum
 {

rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/WithAutoloadPathsTest.php

@@ -6,4 +6,5 @@
 use Rector\Config\RectorConfig;
 
 return RectorConfig::configure()
-    ->withRules([EnumCaseToPascalCaseRector::class]);
+    ->withRules([EnumCaseToPascalCaseRector::class])
+    ->withAutoloadPaths([__DIR__ . '/../Source/Autoload']);

rules-tests/CodingStyle/Rector/Enum_/EnumCaseToPascalCaseRector/config/configured_rule.php

@@ -4,19 +4,15 @@
 
 namespace Rector\CodingStyle\Rector\Enum_;
 
+use PHPStan\Reflection\ClassReflection;
 use PhpParser\Node;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Name;
 use PhpParser\Node\Stmt\Enum_;
 use PhpParser\Node\Stmt\EnumCase;
-use PHPStan\BetterReflection\Reflection\ReflectionEnum;
-use PHPStan\BetterReflection\Reflector\DefaultReflector;
-use PHPStan\BetterReflection\Reflector\Exception\IdentifierNotFound;
-use PHPStan\Reflection\ReflectionProvider;
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
-use Rector\NodeTypeResolver\Reflection\BetterReflection\SourceLocatorProvider\DynamicSourceLocatorProvider;
 use Rector\Rector\AbstractRector;
 use Rector\Skipper\FileSystem\PathNormalizer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -27,12 +23,6 @@
  */
 final class EnumCaseToPascalCaseRector extends AbstractRector
 {
-    public function __construct(
-        private readonly ReflectionProvider $reflectionProvider,
-        private readonly DynamicSourceLocatorProvider $dynamicSourceLocatorProvider,
-    ) {
-    }
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -122,43 +112,40 @@ private function refactorClassConstFetch(ClassConstFetch $classConstFetch): ?Nod
             return null;
         }
 
-        if ($this->nodeTypeResolver->getType($classConstFetch->class)->isEnum()->no()) {
-            return null;
-        }
-
         $constName = $classConstFetch->name->toString();
+        $pascalCaseName = $this->convertToPascalCase($constName);
 
-        // Skip "class" constant
-        if ($constName === 'class') {
+        // short circuit if already in pascal case
+        if ($constName === $pascalCaseName) {
             return null;
         }
 
-        $enumClassName = $classConstFetch->class->toString();
-        if (! $this->reflectionProvider->hasClass($enumClassName)) {
+        $classReflection = $this->nodeTypeResolver->getType($classConstFetch->class)
+            ->getObjectClassReflections()[0] ?? null;
+
+        if ($classReflection === null || ! $classReflection->isEnum()) {
             return null;
         }
 
-        $sourceLocator = $this->dynamicSourceLocatorProvider->provide();
-        $defaultReflector = new DefaultReflector($sourceLocator);
-
-        try {
-            $classIdentifier = $defaultReflector->reflectClass($classConstFetch->class->toString());
-        } catch (IdentifierNotFound) {
-            // source is outside the paths defined in withPaths(), eg: vendor
+        if (! $this->isEnumCase($classReflection, $constName, $pascalCaseName)) {
             return null;
         }
 
-        // ensure exactly ReflectionEnum
-        if (! $classIdentifier instanceof ReflectionEnum) {
+        if ($this->isUsedOutsideOfProject($classReflection)) {
             return null;
         }
 
-        // ensure not part of definition in ->withAutoloadPaths()
-        $fileTarget = $classIdentifier->getFileName();
+        $classConstFetch->name = new Identifier($pascalCaseName);
+        return $classConstFetch;
+    }
+
+    private function isUsedOutsideOfProject(ClassReflection $classReflection): bool
+    {
+        $fileTarget = $classReflection->getFileName();
 
         // possibly native
         if ($fileTarget === null) {
-            return null;
+            return true;
         }
 
         $autoloadPaths = SimpleParameterProvider::provideArrayParameter(Option::AUTOLOAD_PATHS);
@@ -168,21 +155,21 @@ private function refactorClassConstFetch(ClassConstFetch $classConstFetch): ?Nod
             $normalizedAutoloadPath = PathNormalizer::normalize($autoloadPath);
 
             if ($autoloadPath === $fileTarget) {
-                return null;
+                return true;
             }
 
             if (str_starts_with($normalizedFileTarget, $normalizedAutoloadPath . '/')) {
-                return null;
+                return true;
             }
         }
 
-        $pascalCaseName = $this->convertToPascalCase($constName);
-        if ($constName !== $pascalCaseName) {
-            $classConstFetch->name = new Identifier($pascalCaseName);
-            return $classConstFetch;
-        }
+        return false;
+    }
 
-        return null;
+    private function isEnumCase(ClassReflection $classReflection, string $name, string $pascalName): bool
+    {
+        // the enum case might have already been renamed, need to check both
+        return $classReflection->hasEnumCase($name) || $classReflection->hasEnumCase($pascalName);
     }
 
     private function convertToPascalCase(string $name): string