Fix RemoveDuplicatedCaseInSwitchRector behavior (#7173)

* Fix `RemoveDuplicatedCaseInSwitchRector` behavior

* fix cs

* fix and test case

Author: mspirkov

.gitignore

@@ -4,6 +4,9 @@ composer.lock
 # PHPStorm meta files
 .idea/
 
+# VS Code files
+.vscode
+
 .phpunit.result.cache
 # since PHPUnit 10
 .phpunit.cache

rules-tests/DeadCode/Rector/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/consecutive_equal_case_stmts4.php.inc

@@ -0,0 +1,46 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class ConsecutiveEqualCaseStmts4
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+                return 'A';
+            case 'b':
+                return 'C';
+            case 'd':
+            case 'c':
+            case 'f':
+            default:
+                return 'C';
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class ConsecutiveEqualCaseStmts4
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+                return 'A';
+            case 'b':
+            case 'd':
+            case 'c':
+            case 'f':
+            default:
+                return 'C';
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/consecutive_equal_case_stmts5.php.inc

@@ -0,0 +1,46 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class ConsecutiveEqualCaseStmts5
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+                return 'A';
+            case 'b':
+                return 'C';
+            default:
+            case 'd':
+            case 'c':
+            case 'f':
+                return 'C';
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class ConsecutiveEqualCaseStmts5
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+                return 'A';
+            case 'b':
+            default:
+            case 'd':
+            case 'c':
+            case 'f':
+                return 'C';
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/different_indirect_duplicated4.php.inc

@@ -0,0 +1,56 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class DifferentIndirectDuplicated4
+{
+    public function run()
+    {
+        switch ($item) {
+            case 'a':
+            case 'b':
+                return 'val1';
+            case 'c':
+                return 'val2';
+            case 'd':
+            case 'e':
+                return 'val5';
+            case 'f':
+            case 'g':
+            case 'h':
+                return 'val2';
+            case 'i':
+                return 'val3';
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class DifferentIndirectDuplicated4
+{
+    public function run()
+    {
+        switch ($item) {
+            case 'a':
+            case 'b':
+                return 'val1';
+            case 'c':
+            case 'f':
+            case 'g':
+            case 'h':
+                return 'val2';
+            case 'd':
+            case 'e':
+                return 'val5';
+            case 'i':
+                return 'val3';
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/different_indirect_duplicated5.php.inc

@@ -0,0 +1,53 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class DifferentIndirectDuplicated5
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+                return 'A';
+            case 'b':
+                return 'C';
+            case 'd':
+            case 'c':
+            case 'f':
+                return 'C';
+            case 'e':
+                return 'A';
+            default:
+                return 'C';
+            case 'i':
+                return 'A';
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class DifferentIndirectDuplicated5
+{
+    public function run($name)
+    {
+        switch ($name) {
+            case 'a':
+            case 'e':
+            case 'i':
+                return 'A';
+            case 'b':
+            case 'd':
+            case 'c':
+            case 'f':
+            default:
+                return 'C';
+        }
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/no_stmts_without_comments.php.inc

@@ -0,0 +1,47 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class NoStmtsWithoutComments
+{
+    public function run($foo)
+    {
+        switch ($foo) {
+            case 'A':
+                break;
+            case 'B':
+            case 'C':
+                break;
+            case 'D':
+                $type = 'BAR';
+                break;
+            case 'E':
+            case 'F':
+            default:
+                break;
+        }
+    }
+}
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;
+
+class NoStmtsWithoutComments
+{
+    public function run($foo)
+    {
+        switch ($foo) {
+            case 'A':
+            case 'B':
+            case 'C':
+            case 'E':
+            case 'F':
+            default:
+                break;
+            case 'D':
+                $type = 'BAR';
+                break;
+        }
+    }
+}