fix: remove empty construct when parent has no construct (#7239)

* fix: remove empty construct when parent has no construct

* chore: updates

Author: calebdw

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Fixture/removed_empty_construct_when_no_parent_construct.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source\ParentWithoutConstructor;
+
+class RemovedEmptyConstructWhenNoParentConstruct extends ParentWithoutConstructor
+{
+    public function __construct()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source\ParentWithoutConstructor;
+
+class RemovedEmptyConstructWhenNoParentConstruct extends ParentWithoutConstructor
+{
+}
+
+?>

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Fixture/skip_construct_from_trait.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source\TraitWithConstructor;
+
+class SkipConstructFromTrait
+{
+    use TraitWithConstructor;
+
+    public function __construct()
+    {
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Source/ParentWithoutConstructor.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source;
+
+class ParentWithoutConstructor
+{
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector/Source/TraitWithConstructor.php

@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveEmptyClassMethodRector\Source;
+
+trait TraitWithConstructor
+{
+    public function __construct()
+    {
+        return;
+    }
+}

rules/DeadCode/Rector/ClassMethod/RemoveEmptyClassMethodRector.php

@@ -157,11 +157,6 @@ private function shouldSkipClassMethod(Class_ $class, ClassMethod $classMethod):
             return true;
         }
 
-        if ($this->isName($classMethod, MethodName::CONSTRUCT)) {
-            // has parent class?
-            return $class->extends instanceof FullyQualified;
-        }
-
         if ($this->isName($classMethod, MethodName::CLONE)) {
             return ! $classMethod->isPublic();
         }