From 3d03f93b19def48b1ca3d62793a5af10e03b1a3b Mon Sep 17 00:00:00 2001 From: Caleb White Date: Mon, 4 Aug 2025 22:25:15 -0500 Subject: [PATCH 1/2] fix: skip variable assignments in get_defined_vars --- .../Fixture/skip_in_get_defined_vars.php.inc | 14 ++++++++++++++ .../Assign/RemoveUnusedVariableAssignRector.php | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 rules-tests/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector/Fixture/skip_in_get_defined_vars.php.inc diff --git a/rules-tests/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector/Fixture/skip_in_get_defined_vars.php.inc b/rules-tests/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector/Fixture/skip_in_get_defined_vars.php.inc new file mode 100644 index 00000000000..0d8ec21d667 --- /dev/null +++ b/rules-tests/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector/Fixture/skip_in_get_defined_vars.php.inc @@ -0,0 +1,14 @@ + diff --git a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php index e902b81150a..794d40fb479 100644 --- a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php +++ b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php @@ -154,7 +154,7 @@ private function shouldSkip(array $stmts): bool return false; } - return $this->isName($node, 'compact'); + return $this->isName($node, 'compact') || $this->isName($node, 'get_defined_vars'); }); } From e581023d93b16d9cfd795b093c1167ef553d8b3c Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 5 Aug 2025 11:05:02 +0700 Subject: [PATCH 2/2] Update rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php --- .../DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php index 794d40fb479..04e8d36e32a 100644 --- a/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php +++ b/rules/DeadCode/Rector/Assign/RemoveUnusedVariableAssignRector.php @@ -154,7 +154,7 @@ private function shouldSkip(array $stmts): bool return false; } - return $this->isName($node, 'compact') || $this->isName($node, 'get_defined_vars'); + return $this->isNames($node, ['compact', 'get_defined_vars']); }); }