From a0ec489cda3be4feb485be5928f9c6c5844b8e9b Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Tue, 26 Aug 2025 17:59:08 +0700 Subject: [PATCH 1/2] [TypeDeclaration] Clean up type based on doc check on AddMethodCallBasedStrictParamTypeRector --- rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php | 5 ----- 1 file changed, 5 deletions(-) diff --git a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php index c6753f7d1db..2873d6f500b 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php +++ b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php @@ -69,11 +69,6 @@ private function resolveStrictArgValueType(Arg $arg): Type return new MixedType(); } - $type = $this->nodeTypeResolver->getType($arg->value); - if (! $type->equals($argValueType) && $this->typeComparator->isSubtype($type, $argValueType)) { - return $type; - } - return $argValueType; } From d5410ea13abceb6b367b5c4af5c8c7b7f9cf0a94 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Tue, 26 Aug 2025 11:02:15 +0000 Subject: [PATCH 2/2] [ci-review] Rector Rectify --- rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php index 2873d6f500b..47adc005f04 100644 --- a/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php +++ b/rules/TypeDeclaration/NodeAnalyzer/CallTypesResolver.php @@ -16,7 +16,6 @@ use PHPStan\Type\UnionType; use Rector\NodeTypeResolver\NodeTypeResolver; use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory; -use Rector\NodeTypeResolver\TypeComparator\TypeComparator; use Rector\StaticTypeMapper\Resolver\ClassNameFromObjectTypeResolver; final readonly class CallTypesResolver @@ -24,8 +23,7 @@ public function __construct( private NodeTypeResolver $nodeTypeResolver, private TypeFactory $typeFactory, - private ReflectionProvider $reflectionProvider, - private TypeComparator $typeComparator + private ReflectionProvider $reflectionProvider ) { }