From 1e857f650d8b192363f65cfbace8edeceaed2112 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Thu, 11 Sep 2025 18:36:26 +0200 Subject: [PATCH] move 2 docblock rules to type-declaration-docblock set --- config/set/type-declaration-docblocks.php | 4 ++++ .../DocblockReturnArrayFromDirectArrayInstanceRector.php | 8 +++----- src/Config/Level/TypeDeclarationLevel.php | 2 -- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/config/set/type-declaration-docblocks.php b/config/set/type-declaration-docblocks.php index 278fa71ca72..ef4ba27d115 100644 --- a/config/set/type-declaration-docblocks.php +++ b/config/set/type-declaration-docblocks.php @@ -3,6 +3,8 @@ declare(strict_types=1); use Rector\Config\RectorConfig; +use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnArrayDocblockBasedOnArrayMapRector; +use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnDocblockForScalarArrayFromAssignsRector; use Rector\TypeDeclarationDocblocks\Rector\Class_\DocblockVarFromParamDocblockInConstructorRector; use Rector\TypeDeclarationDocblocks\Rector\ClassMethod\DocblockGetterReturnArrayFromPropertyDocblockVarRector; @@ -11,6 +13,8 @@ */ return static function (RectorConfig $rectorConfig): void { $rectorConfig->rules([ + AddReturnArrayDocblockBasedOnArrayMapRector::class, + AddReturnDocblockForScalarArrayFromAssignsRector::class, DocblockVarFromParamDocblockInConstructorRector::class, DocblockVarFromParamDocblockInConstructorRector::class, DocblockGetterReturnArrayFromPropertyDocblockVarRector::class, diff --git a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector.php b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector.php index bdf260fbef5..1e5e51fdb2e 100644 --- a/rules/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector.php +++ b/rules/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector.php @@ -4,7 +4,6 @@ namespace Rector\TypeDeclarationDocblocks\Rector\ClassMethod; -use PHPStan\Type\Type; use PhpParser\Node; use PhpParser\Node\Expr\Array_; use PhpParser\Node\Stmt\ClassMethod; @@ -18,6 +17,7 @@ use PHPStan\Type\IntegerType; use PHPStan\Type\MixedType; use PHPStan\Type\StringType; +use PHPStan\Type\Type; use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory; use Rector\Comments\NodeDocBlock\DocBlockUpdater; use Rector\Rector\AbstractRector; @@ -150,10 +150,8 @@ private function constantToGenericType(Type $type): Type return new MixedType(); } - private function createArrayGenericTypeNode( - Type $keyType, - Type $itemType - ): GenericTypeNode { + private function createArrayGenericTypeNode(Type $keyType, Type $itemType): GenericTypeNode + { $keyDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($keyType); $itemDocTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPHPStanPhpDocTypeNode($itemType); diff --git a/src/Config/Level/TypeDeclarationLevel.php b/src/Config/Level/TypeDeclarationLevel.php index 60246def2dd..f2414fc4751 100644 --- a/src/Config/Level/TypeDeclarationLevel.php +++ b/src/Config/Level/TypeDeclarationLevel.php @@ -18,7 +18,6 @@ use Rector\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeBasedOnPHPUnitDataProviderRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddParamTypeFromPropertyTypeRector; -use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnDocblockForScalarArrayFromAssignsRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationBasedOnParentClassMethodRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeFromTryCatchTypeRector; use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector; @@ -145,6 +144,5 @@ final class TypeDeclarationLevel // possibly based on docblocks, but also helpful, intentionally last AddArrayFunctionClosureParamTypeRector::class, TypedPropertyFromDocblockSetUpDefinedRector::class, - AddReturnDocblockForScalarArrayFromAssignsRector::class, ]; }