From 0285265768a0be124456a3d3e8a07f5a95bca4c0 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 15 Sep 2025 06:45:18 +0700 Subject: [PATCH 1/2] [CodeQuality] Skip init not empty array on InlineArrayReturnAssignRector --- .../Fixture/skip_init_not_empty_array.php.inc | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_init_not_empty_array.php.inc diff --git a/rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_init_not_empty_array.php.inc b/rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_init_not_empty_array.php.inc new file mode 100644 index 00000000000..1638e48ea10 --- /dev/null +++ b/rules-tests/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector/Fixture/skip_init_not_empty_array.php.inc @@ -0,0 +1,17 @@ + 'type', + 'id' => (string) $someObject->getId(), + ]; + $message['link'] = $this->getSome($someObject); + + return $message; + } +} \ No newline at end of file From a698681d0ccffaff65f936cd76501f67e983aff7 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Mon, 15 Sep 2025 06:48:41 +0700 Subject: [PATCH 2/2] fixed --- .../Rector/ClassMethod/InlineArrayReturnAssignRector.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php b/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php index a1a823fa318..3adabdd0202 100644 --- a/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php +++ b/rules/CodeQuality/Rector/ClassMethod/InlineArrayReturnAssignRector.php @@ -215,6 +215,10 @@ private function resolveDefaultEmptyArrayAssign(array $stmts, string $returnedVa continue; } + if ($assign->expr->items !== []) { + continue; + } + return $assign; }