diff --git a/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc new file mode 100644 index 00000000000..cd75ac6e747 --- /dev/null +++ b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc @@ -0,0 +1,38 @@ +run(explode(':', '1:1')); + } + + private function run(array $items) + { + } +} + +?> +----- +run(explode(':', '1:1')); + } + + /** + * @param string[] $items + */ + private function run(array $items) + { + } +} + +?> diff --git a/src/NodeTypeResolver/NodeTypeResolver.php b/src/NodeTypeResolver/NodeTypeResolver.php index 6cde992ec83..9baa9932767 100644 --- a/src/NodeTypeResolver/NodeTypeResolver.php +++ b/src/NodeTypeResolver/NodeTypeResolver.php @@ -34,11 +34,13 @@ use PHPStan\Type\Constant\ConstantBooleanType; use PHPStan\Type\Constant\ConstantStringType; use PHPStan\Type\ErrorType; +use PHPStan\Type\IntegerType; use PHPStan\Type\MixedType; use PHPStan\Type\NeverType; use PHPStan\Type\NullType; use PHPStan\Type\ObjectType; use PHPStan\Type\ObjectWithoutClassType; +use PHPStan\Type\StringType; use PHPStan\Type\ThisType; use PHPStan\Type\Type; use PHPStan\Type\TypeCombinator; @@ -178,6 +180,11 @@ public function getType(Node $node): Type } } + // correction for explode() that always returns array + if ($node instanceof FuncCall && $node->name instanceof Name && $node->name->toString() === 'explode') { + return new ArrayType(new IntegerType(), new StringType()); + } + if ($node instanceof Ternary) { $ternaryType = $this->resolveTernaryType($node); if (! $ternaryType instanceof MixedType) {