From d699b0445e76490017030911ff671006e84ecf41 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 26 Sep 2025 00:17:31 +0200 Subject: [PATCH 1/2] add fixture --- .../Fixture/from_explode.php.inc | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc diff --git a/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc new file mode 100644 index 00000000000..7f474f5e572 --- /dev/null +++ b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc @@ -0,0 +1,39 @@ +run(explode(':', '1:1')); + } + + private function run(array $items) + { + } +} + +?> +----- +run(explode(':', '1:1')); + } + + /** + * @param string[] $items + */ + private function run(array $items) + { + } +} + +?> + From 746df9a097191e4520f24e3f665bf13544798839 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 26 Sep 2025 00:21:04 +0200 Subject: [PATCH 2/2] fix adding string[] in explode() for ClassMethodArrayDocblockParamFromLocalCallsRector --- .../Fixture/from_explode.php.inc | 1 - src/NodeTypeResolver/NodeTypeResolver.php | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc index 7f474f5e572..cd75ac6e747 100644 --- a/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc +++ b/rules-tests/TypeDeclarationDocblocks/Rector/Class_/ClassMethodArrayDocblockParamFromLocalCallsRector/Fixture/from_explode.php.inc @@ -36,4 +36,3 @@ final class FromExplode } ?> - diff --git a/src/NodeTypeResolver/NodeTypeResolver.php b/src/NodeTypeResolver/NodeTypeResolver.php index 6cde992ec83..9baa9932767 100644 --- a/src/NodeTypeResolver/NodeTypeResolver.php +++ b/src/NodeTypeResolver/NodeTypeResolver.php @@ -34,11 +34,13 @@ use PHPStan\Type\Constant\ConstantBooleanType; use PHPStan\Type\Constant\ConstantStringType; use PHPStan\Type\ErrorType; +use PHPStan\Type\IntegerType; use PHPStan\Type\MixedType; use PHPStan\Type\NeverType; use PHPStan\Type\NullType; use PHPStan\Type\ObjectType; use PHPStan\Type\ObjectWithoutClassType; +use PHPStan\Type\StringType; use PHPStan\Type\ThisType; use PHPStan\Type\Type; use PHPStan\Type\TypeCombinator; @@ -178,6 +180,11 @@ public function getType(Node $node): Type } } + // correction for explode() that always returns array + if ($node instanceof FuncCall && $node->name instanceof Name && $node->name->toString() === 'explode') { + return new ArrayType(new IntegerType(), new StringType()); + } + if ($node instanceof Ternary) { $ternaryType = $this->resolveTernaryType($node); if (! $ternaryType instanceof MixedType) {