From c938c5a123b4895b7ffccf2de12b65763dcde39e Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Fri, 10 Oct 2025 02:30:54 +0700 Subject: [PATCH 1/2] [TypeDeclarationDocblocks] Handle repeated item type on DocblockReturnArrayFromDirectArrayInstanceRector --- .../Fixture/repeated_item_type.php.inc | 66 +++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector/Fixture/repeated_item_type.php.inc diff --git a/rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector/Fixture/repeated_item_type.php.inc b/rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector/Fixture/repeated_item_type.php.inc new file mode 100644 index 00000000000..9bc257ac9f9 --- /dev/null +++ b/rules-tests/TypeDeclarationDocblocks/Rector/ClassMethod/DocblockReturnArrayFromDirectArrayInstanceRector/Fixture/repeated_item_type.php.inc @@ -0,0 +1,66 @@ + $this->partitionName, + 'replica_number' => $this->replicaNumber, + 'timeout' => $this->timeout, + ]; + + $params = array_filter($params); + + return [ + 'collection_name' => $this->collectionName, + 'params' => $params, + ]; + } +} + +?> +----- +> + */ + public function toRequestPayload(): array + { + $params = [ + 'partition_name' => $this->partitionName, + 'replica_number' => $this->replicaNumber, + 'timeout' => $this->timeout, + ]; + + $params = array_filter($params); + + return [ + 'collection_name' => $this->collectionName, + 'params' => $params, + ]; + } +} + +?> From 580d7bb2af35a32cad6846083f544a035a3cd890 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 11 Oct 2025 07:17:58 +0700 Subject: [PATCH 2/2] fix --- .../ValueObject/Type/BracketsAwareUnionTypeNode.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php b/src/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php index 3325bf3ba07..15cdcc4252a 100644 --- a/src/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php +++ b/src/BetterPhpDocParser/ValueObject/Type/BracketsAwareUnionTypeNode.php @@ -25,6 +25,7 @@ public function __construct( */ public function __toString(): string { + $this->types = array_unique($this->types, SORT_REGULAR); if (! $this->isWrappedInBrackets) { return implode('|', $this->types); }