From db7a346b6b90c097b2cd4c2fdd07eb5df4b622e4 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 11 Oct 2025 17:28:08 +0700 Subject: [PATCH 1/2] [CodingStyle] Skip compare binary op on BinaryOpStandaloneAssignsToDirectRector --- .../Fixture/skip_compare_binary_op.php.inc | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_binary_op.php.inc diff --git a/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_binary_op.php.inc b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_binary_op.php.inc new file mode 100644 index 00000000000..4f9d2a3996a --- /dev/null +++ b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_binary_op.php.inc @@ -0,0 +1,14 @@ + $second; + } +} From 446aff4a2d08af248e88b072f8ad4f70c2682a51 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Sat, 11 Oct 2025 17:30:41 +0700 Subject: [PATCH 2/2] fix --- .../Fixture/skip_compare_assign_op.php.inc | 14 ++++++++++++++ .../BinaryOpStandaloneAssignsToDirectRector.php | 4 ++++ 2 files changed, 18 insertions(+) create mode 100644 rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_assign_op.php.inc diff --git a/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_assign_op.php.inc b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_assign_op.php.inc new file mode 100644 index 00000000000..5da4308b5e0 --- /dev/null +++ b/rules-tests/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector/Fixture/skip_compare_assign_op.php.inc @@ -0,0 +1,14 @@ + $second; + } +} diff --git a/rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php b/rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php index 229813b3cf8..e4c9eaf1378 100644 --- a/rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php +++ b/rules/CodingStyle/Rector/ClassMethod/BinaryOpStandaloneAssignsToDirectRector.php @@ -137,6 +137,10 @@ private function matchToVariableAssignExpr(Stmt $stmt): ?VariableAndExprAssign return null; } + if ($assign->expr instanceof BinaryOp) { + return null; + } + return new VariableAndExprAssign($assign->var, $assign->expr); } }