From 1f2dd8227b45c11508bd1bffb733e24050799531 Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Mon, 13 Oct 2025 15:17:14 +0700
Subject: [PATCH 1/2] [TypeDeclaration] Skip possible int and falsy on
 AddParamStringTypeFromSprintfUseRector

---
 .../Fixture/skip_possible_int.php.inc          | 18 ++++++++++++++++++
 .../Fixture/skip_with_empty_check.php.inc      | 16 ++++++++++++++++
 .../VariableInSprintfMaskMatcher.php           |  9 +++++++--
 3 files changed, 41 insertions(+), 2 deletions(-)
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_possible_int.php.inc
 create mode 100644 rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_with_empty_check.php.inc

diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_possible_int.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_possible_int.php.inc
new file mode 100644
index 00000000000..0c84793eaf9
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_possible_int.php.inc
@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamStringTypeFromSprintfUseRector\Fixture;
+
+class SkipPossibleInt
+{
+    public function error_handler_errortype($errno): string
+    {
+        return match ($errno) {
+            \E_USER_ERROR, \E_ERROR, \E_COMPILE_ERROR, \E_RECOVERABLE_ERROR => 'Fatal error',
+            \E_PARSE => 'Parse error',
+            \E_USER_WARNING, \E_WARNING, \E_COMPILE_WARNING => 'Warning',
+            \E_USER_NOTICE, \E_NOTICE => 'Notice',
+            \E_USER_DEPRECATED, \E_DEPRECATED => 'Deprecated',
+            default => sprintf('Unknown (%s)', $errno),
+        };
+    }
+}
\ No newline at end of file
diff --git a/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_with_empty_check.php.inc b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_with_empty_check.php.inc
new file mode 100644
index 00000000000..85d1f03673d
--- /dev/null
+++ b/rules-tests/TypeDeclaration/Rector/ClassMethod/AddParamStringTypeFromSprintfUseRector/Fixture/skip_with_empty_check.php.inc
@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddParamStringTypeFromSprintfUseRector\Fixture;
+
+class SkipWithEmptyCheck
+{
+    public function columnExpr($columnExpr, string $default): string
+    {
+        // $columnExpr can be anything empty: false | null | '' | 0 | '0' | []
+        if (empty($columnExpr)) {
+            return $default;
+        }
+
+        return sprintf("hello %s", $columnExpr);
+    }
+}
\ No newline at end of file
diff --git a/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php b/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
index e0200020f0b..5f2814d606e 100644
--- a/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
+++ b/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
@@ -10,6 +10,8 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\UnionType;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpParser\Node\BetterNodeFinder;
@@ -47,8 +49,6 @@ public function matchMask(ClassMethod|Function_ $functionLike, string $variableN
             /** @var Arg $messageArg */
             $messageArg = array_shift($args);
 
-            $type = $this->nodeTypeResolver->getType($messageArg->value);
-
             $messageValue = $this->valueResolver->getValue($messageArg->value);
             if (! is_string($messageValue)) {
                 continue;
@@ -75,6 +75,11 @@ public function matchMask(ClassMethod|Function_ $functionLike, string $variableN
                     continue;
                 }
 
+                $type = $this->nodeTypeResolver->getType($arg->value);
+                if ($type instanceof MixedType && $type->getSubtractedType() instanceof UnionType) {
+                    continue;
+                }
+
                 return true;
             }
         }

From 2815193fbb8461dcb6c65ec1c3fdac14e45269db Mon Sep 17 00:00:00 2001
From: Abdul Malik Ikhsan <samsonasik@gmail.com>
Date: Mon, 13 Oct 2025 15:18:40 +0700
Subject: [PATCH 2/2] us native

---
 .../NodeAnalyzer/VariableInSprintfMaskMatcher.php               | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php b/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
index 5f2814d606e..97af4db98f4 100644
--- a/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
+++ b/rules/TypeDeclaration/NodeAnalyzer/VariableInSprintfMaskMatcher.php
@@ -75,7 +75,7 @@ public function matchMask(ClassMethod|Function_ $functionLike, string $variableN
                     continue;
                 }
 
-                $type = $this->nodeTypeResolver->getType($arg->value);
+                $type = $this->nodeTypeResolver->getNativeType($arg->value);
                 if ($type instanceof MixedType && $type->getSubtractedType() instanceof UnionType) {
                     continue;
                 }