Incorrect behavior of CoversAnnotationWithValueToAttributeRector

[TimelessTron]

Bug Report

Subject	Details
Rector version	2.0.16
PHP	8.3
PHPUnit	10.5.46
PHPStan	2.1.16
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/9330ed38-6292-464c-adf2-4b627bfd01d0

<?php

namespace App {
    trait SomeTrait {
    }
    class OtherStuff {
        public static function Inject(): void
        {}
    }
}

namespace App\Test {
    use App\SomeTrait;
    use PHPUnit\Framework\TestCase;

    /**
     * @covers \App\SomeTrait
     */
    final class SomeTraitTest extends TestCase
    {
        /**
         * @covers \App\OtherStuff::Inject
         */
        public function testYourThinks(): void
        {}
    }
}

<?php

     use App\SomeTrait;
     use PHPUnit\Framework\TestCase;
 
-    /**
-     * @covers \App\SomeTrait
-     */
+    #[\PHPUnit\Framework\Attributes\CoversTrait(\App\SomeTrait::class)]
+    #[\PHPUnit\Framework\Attributes\CoversMethod(\App\OtherStuff::class, 'Inject')]
     final class SomeTraitTest extends TestCase
     {
-        /**
-         * @covers \App\OtherStuff::Inject
-         */
         public function testYourThinks(): void
         {}
     }
 }

<?php

declare(strict_types=1);

use Rector\PHPUnit\Set\PHPUnitSetList;
use Rector\Config\RectorConfig;

return RectorConfig::configure()
    ->withSets([
        PHPUnitSetList::PHPUNIT_100,
    ])
;

Responsible rules

• CoversAnnotationWithValueToAttributeRector

Expected Behavior

In the code we see an example of a test. Covers are converted into anotations.
This was only partially implemented in PHPunit 10. The class CoversMethod was only added in PHPUnit 11.1.0

(sebastianbergmann/phpunit@3efde166f8370f1620a72f72c0c996a035cfe1f7)[https://github.com/sebastianbergmann/phpunit/commit/3efde166f8370f1620a72f72c0c996a035cfe1f7]

The class \PHPUnit\Framework\Attributes\CoversMethod does not exist at this point.

The expected behavior would be that in version PHPunt 10 the class CoversMethod is excluded.

[samsonasik]

@TimelessTron please try latest dev-main and verify if it now works on phpunit 10, thank you.

composer config minimum-stability dev
composer config prefer-stable true
composer update rector/rector:dev-main

[TimelessTron]

<?php

+    #[CoversClass(\App\SomeException::class)]
     final class SomeTraitTest extends TestCase
     {
-        /**
-         * @covers \App\OtherStuff::Inject
-         * @covers \App\SomeException
-         */
         public function testYourThinks(): void
         {}
     }
 }

✅ => The anotation for CoversMethod is no longer created.
❌ => The covers for the methods are deleted.

[samsonasik]

is this already correct or you found some issue on it?

[TimelessTron]

The class calls are reset by the anotation CoversClass and the declaration @covers \App\SomeClass is removed. This behavior is correct.

The method calls are now no longer set as an anotation CoversMethod. (Which is correct in PHPUnit 10) However, the declarations @covers \App\SomeClass::SomeMethod are removed. This is wrong.
As long as CoversMethod is not set, @covers ...::SomeMethod must remain set.

<?php

+    #[CoversClass(\App\SomeException::class)]
     final class SomeTraitTest extends TestCase
     {
        /**
         * @covers \App\OtherStuff::Inject
-        * @covers \App\SomeException
         */
         public function testYourThinks(): void
         {}
     }
 }

⬆️ That would be correct.

[samsonasik]

should be handled at:

• Only remove @covers when target exists rector-phpunit#494

wait for github to pick up merge

[samsonasik]

@TimelessTron please try composer update once more on dev-main and verify if it now works on phpunit 10, thank you.

[TimelessTron]

@samsonasik Thank you for the quick implementation.

I have tested it with phpunit 10.5.46. It works as expected.
I have also tested it with phpunit 11.5.21. Everything works as expected here too.

The bug no longer exists. 🥇

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.