PR shown as "passing" in migration, should be "conflicts"

[Carreau]

conda-forge/memray-feedstock#56 has been likely conflict for 3weeks, but is still in it's json file in cf-graph-countyfair $ cat pr_json/4/1/4/9/3/2986639532.json (https://github.com/regro/cf-graph-countyfair/blob/master/pr_json/4/1/4/9/3/2986639532.json) still mergeable "clean".

EDIT: another one: conda-forge/pygit2-feedstock#96

This file was not updated in a month, my guess by bad luck as only some PRs get updated from update_pr ? That randomly update only 50% of them ?

Or any other ideas ? Maybe keep track of when the file was last update and always update the ~20 oldest updated ?

[Carreau]

it looks like

def lazy_update_pr_json

passes 'if-modifed-since', and the data has indeed be modified, the PR has not, so nothings updates.

[Carreau]

well It's late here I'll resume that tomorrow.

[Carreau]

And I did post a comment on the issue, so I'm stupid, because now it's modified; but I'm sure it's not the only one.

[Carreau]

Ha, I caught it red-handed,

304,

$ curl -v -H "If-Modified-Since: Fri, 07 Nov 2025 01:37:26 GMT"    https://api.github.com/repos/conda-forge/pygit2-feedstock/pulls/96
* Host api.github.com:443 was resolved.
* IPv6: (none)
* IPv4: 140.82.121.6
*   Trying 140.82.121.6:443...
* ALPN: curl offers h2,http/1.1
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
*  CAfile: /Users/bussonniermatthias/miniconda3/envs/arm64/ssl/cacert.pem
*  CApath: none
* TLSv1.3 (IN), TLS handshake, Server hello (2):
* TLSv1.3 (IN), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (IN), TLS handshake, Encrypted Extensions (8):
* TLSv1.3 (IN), TLS handshake, Certificate (11):
* TLSv1.3 (IN), TLS handshake, CERT verify (15):
* TLSv1.3 (IN), TLS handshake, Finished (20):
* TLSv1.3 (OUT), TLS change cipher, Change cipher spec (1):
* TLSv1.3 (OUT), TLS handshake, Finished (20):
* SSL connection using TLSv1.3 / TLS_AES_128_GCM_SHA256 / x25519 / id-ecPublicKey
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=*.github.com
*  start date: Feb  5 00:00:00 2025 GMT
*  expire date: Feb  5 23:59:59 2026 GMT
*  subjectAltName: host "api.github.com" matched cert's "*.github.com"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=Sectigo Limited; CN=Sectigo ECC Domain Validation Secure Server CA
*  SSL certificate verify ok.
*   Certificate level 0: Public key type EC/prime256v1 (256/128 Bits/secBits), signed using ecdsa-with-SHA256
*   Certificate level 1: Public key type EC/prime256v1 (256/128 Bits/secBits), signed using ecdsa-with-SHA384
*   Certificate level 2: Public key type EC/secp384r1 (384/192 Bits/secBits), signed using ecdsa-with-SHA384
* Connected to api.github.com (140.82.121.6) port 443
* using HTTP/2
* [HTTP/2] [1] OPENED stream for https://api.github.com/repos/conda-forge/pygit2-feedstock/pulls/96
* [HTTP/2] [1] [:method: GET]
* [HTTP/2] [1] [:scheme: https]
* [HTTP/2] [1] [:authority: api.github.com]
* [HTTP/2] [1] [:path: /repos/conda-forge/pygit2-feedstock/pulls/96]
* [HTTP/2] [1] [user-agent: curl/8.10.1]
* [HTTP/2] [1] [accept: */*]
* [HTTP/2] [1] [if-modified-since: Fri, 07 Nov 2025 01:37:26 GMT]
> GET /repos/conda-forge/pygit2-feedstock/pulls/96 HTTP/2
> Host: api.github.com
> User-Agent: curl/8.10.1
> Accept: */*
> If-Modified-Since: Fri, 07 Nov 2025 01:37:26 GMT
>
* Request completely sent off
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
< HTTP/2 304
< date: Fri, 05 Dec 2025 07:52:41 GMT
< content-type: application/json; charset=utf-8
< cache-control: public, max-age=60, s-maxage=60
< vary: Accept,Accept-Encoding, Accept, X-Requested-With
< etag: W/"34640930ab76d010fa78c4a4736649010ae6fc3693cd6a40ea9810c7e1be3a94"
< last-modified: Fri, 07 Nov 2025 01:37:26 GMT
< x-github-media-type: github.v3; format=json
< x-github-api-version-selected: 2022-11-28
< access-control-expose-headers: ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset
< access-control-allow-origin: *
< strict-transport-security: max-age=31536000; includeSubdomains; preload
< x-frame-options: deny
< x-content-type-options: nosniff
< x-xss-protection: 0
< referrer-policy: origin-when-cross-origin, strict-origin-when-cross-origin
< content-security-policy: default-src 'none'
< server: github.com
< accept-ranges: bytes
< x-ratelimit-limit: 60
< x-ratelimit-remaining: 44
< x-ratelimit-reset: 1764924400
< x-ratelimit-resource: core
< x-ratelimit-used: 16
< x-github-request-id: E033:6B96E:3642FF7:3257108:69328F49
<
* Connection #0 to host api.github.com left intact
* 

So you can't trust the last modified !

[Carreau]

ETag seem to be ok (to check).