feat: Refactor lint/format methods for Robocop 8.0+

Author: bhirsz

packages/language_server/src/robotcode/language_server/robotframework/parts/formatting.py

@@ -83,17 +83,26 @@ def format_robocop(
 
         config_manager = self.parent.robocop_helper.get_config_manager(workspace_folder)
 
+        source = document.uri.to_path()
         config = config_manager.get_config_for_source_file(document.uri.to_path())
 
         if range is not None:
             config.formatter.start_line = range.start.line + 1
             config.formatter.end_line = range.end.line + 1
 
+        # TODO: not cached, we load all formatters everytime - but it's small cost
         runner = RobocopFormatter(config_manager)
         runner.config = config
 
         model = self.parent.documents_cache.get_model(document, False)
-        _, _, new, _ = runner.format_until_stable(model)
+        if get_robot_version() >= (8, 0):
+            from robocop.source_file import SourceFile
+
+            # overwrite _model to stop Robocop from loading it
+            source_file = SourceFile(path=source, config=config, _model=model)
+            _, _, new, _ = runner.format_until_stable(source_file)
+        else:
+            _, _, new, _ = runner.format_until_stable(model)
 
         if new.text == document.text():
             return None

packages/language_server/src/robotcode/language_server/robotframework/parts/robocop_diagnostics.py

@@ -44,6 +44,15 @@ def get_config(self, document: TextDocument) -> Optional[RoboCopConfig]:
 
         return self.parent.workspace.get_configuration(RoboCopConfig, folder.uri)
 
+    def get_linter(self, workspace_folder: WorkspaceFolder) -> "RobocopLinter":
+        linter = self._robocop_linters.get(workspace_folder, None)
+
+        if linter is None:
+            config_manager = self.parent.robocop_helper.get_config_manager(workspace_folder)
+            linter = RobocopLinter(config_manager)
+            self._robocop_linters[workspace_folder] = linter
+        return linter
+
     @language_id("robotframework")
     @_logger.call
     def collect_diagnostics(
@@ -71,21 +80,20 @@ def collect(self, document: TextDocument, workspace_folder: WorkspaceFolder) ->
         from robocop.linter.rules import RuleSeverity
         from robocop.linter.runner import RobocopLinter
 
-        linter = self._robocop_linters.get(workspace_folder, None)
-
-        if linter is None:
-            config_manager = self.parent.robocop_helper.get_config_manager(workspace_folder)
-
-            config = config_manager.get_config_for_source_file(document.uri.to_path())
-
-            linter = RobocopLinter(config_manager)
-            self._robocop_linters[workspace_folder] = linter
+        linter = self.get_linter(workspace_folder)
 
         source = document.uri.to_path()
-
         config = linter.config_manager.get_config_for_source_file(source)
         model = self.parent.documents_cache.get_model(document, False)
-        diagnostics = linter.run_check(model, source, config)
+
+        if self.parent.robocop_helper.robocop_version >= (8, 0):
+            from robocop.source_file import SourceFile
+
+            # overwrite _model to stop Robocop from loading it
+            source_file = SourceFile(path=source, config=config, _model=model)
+            diagnostics = linter.run_check(source_file)
+        else:
+            diagnostics = linter.run_check(model, source, config)
 
         return [
             Diagnostic(