Skip to content

Commit 5d82eca

Browse files
authored
Merge pull request #117 from rosette-api/nojira-fix-record-similarity
Nojira fix record similarity
2 parents 6d94823 + b176a98 commit 5d82eca

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

rosette/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ def __init__(self):
363363

364364
def validate(self):
365365
"""Internal. Do not use."""
366-
for option in ["records"]: # required
366+
for option in ["records","fields"]: # required
367367
if self[option] is None:
368368
raise RosetteException(
369369
"missingParameter",

tests/test_rosette_api.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,14 @@ def test_for_record_similarity_required_parameters(api, json_response):
978978

979979
params["records"] = {}
980980

981+
with pytest.raises(RosetteException) as e_rosette:
982+
api.record_similarity(params)
983+
984+
assert e_rosette.value.status == 'missingParameter'
985+
assert e_rosette.value.message == 'Required Record Similarity parameter is missing: fields'
986+
987+
params["fields"] = {}
988+
981989
result = api.record_similarity(params)
982990
assert result["name"] == "Babel Street Analytics"
983991
httpretty.disable()

0 commit comments

Comments
 (0)