RCB-602: Sonar cleanup.

Author: seth-mg

rosette/api.py

@@ -113,7 +113,7 @@ def serialize(self, options):
         """serialize keys with values"""
         self.validate()
         values = {}
-        for (key, val) in self.__params.items():
+        for key, val in self.__params.items():
             if val is None:
                 continue
             else:
@@ -240,7 +240,7 @@ def __init__(self):
 
     def validate(self):
         """Internal. Do not use."""
-        for option in ("name", "targetLanguage"):  # required
+        for option in "name", "targetLanguage":  # required
             if self[option] is None:
                 raise RosetteException(
                     "missingParameter",
@@ -275,7 +275,7 @@ def __init__(self):
 
     def validate(self):
         """Internal. Do not use."""
-        for option in ("address1", "address2"):  # required
+        for option in "address1", "address2":  # required
             if self[option] is None:
                 raise RosetteException(
                     "missingParameter",
@@ -317,7 +317,7 @@ def __init__(self):
 
     def validate(self):
         """Internal. Do not use."""
-        for option in ("name1", "name2"):  # required
+        for option in "name1", "name2":  # required
             if self[option] is None:
                 raise RosetteException(
                     "missingParameter",

sonar-project.properties

@@ -1,4 +1,5 @@
 sonar.projectKey=rosette-api-python-binding
 sonar.sources=rosette
+sonar.exclusions=**/tests/**,**/docs/**,**/examples/**
 sonar.python.coverage.reportPaths=coverage.xml
 #sonar.branch.name=RCB-596-pool-size

tests/test_rosette_api.py

@@ -589,7 +589,7 @@ def test_for_content_and_contentUri(api, json_response, doc_params):
     httpretty.register_uri(httpretty.POST, "https://api.rosette.com/rest/v1/entities",
                            body=json_response, status=200, content_type="application/json")
 
-    doc_params['contentUri'] = 'http://google.com'
+    doc_params['contentUri'] = 'https://example.com'
     with pytest.raises(RosetteException) as e_rosette:
         api.entities(doc_params)