better name for option

Author: os97673

ChangeLog.md

@@ -1,6 +1,7 @@
 ## [0.4.34](https://github.com/ruby-debug/ruby-debug-ide/compare/v0.4.33...v0.4.34)
 
-* catchpointDeleted event added (under rm-protocol-extensions flag)
+* catchpointDeleted event added (under --catchpoint-deleted-event flag)
+* --value-as-nested-element to enable just this the extension
 
 ## [0.4.33](https://github.com/ruby-debug/ruby-debug-ide/compare/v0.4.32...v0.4.33)
 

bin/rdebug-ide

@@ -22,7 +22,7 @@ options = OpenStruct.new(
   'evaluation_timeout' => 10,
   'rm_protocol_extensions' => false,
   'catchpoint_deleted_event' => false,
-  'skip_value_attr' => false
+  'value_as_nested_element' => false
 )
 
 opts = OptionParser.new do |opts|
@@ -63,8 +63,8 @@ EOB
   opts.on("--catchpoint-deleted-event", "Enable chatchpointDeleted event") do
     options.catchpoint_deleted_event = true
   end
-  opts.on("--skip-value-attr", "Allow to skip value attribute in variable representation") do
-    options.skip_value_attr = true
+  opts.on("--value-as-nested-element", "Allow to pass variable's value as nested element instead of attribute") do
+    options.value_as_nested_element = true
   end
   opts.separator ""
   opts.separator "Common options:"
@@ -124,9 +124,8 @@ end
 Debugger.keep_frame_binding = options.frame_bind
 Debugger.tracing = options.tracing
 Debugger.evaluation_timeout = options.evaluation_timeout
-Debugger.rm_protocol_extensions = options.rm_protocol_extensions
 Debugger.catchpoint_deleted_event = options.catchpoint_deleted_event || options.rm_protocol_extensions
-Debugger.skip_value_attr = options.skip_value_attr || options.rm_protocol_extensions
+Debugger.value_as_nested_element = options.value_as_nested_element || options.rm_protocol_extensions
 
 Debugger.debug_program(options)
 

lib/ruby-debug-ide.rb

@@ -41,11 +41,11 @@ def cleanup_backtrace(backtrace)
        cleared
     end
 
-    attr_accessor :cli_debug, :xml_debug, :evaluation_timeout, :rm_protocol_extensions
+    attr_accessor :cli_debug, :xml_debug, :evaluation_timeout
     attr_accessor :control_thread
     attr_reader :interface
     # protocol extensions
-    attr_accessor :catchpoint_deleted_event, :skip_value_attr
+    attr_accessor :catchpoint_deleted_event, :value_as_nested_element
 
 
     #

lib/ruby-debug-ide/xml_printer.rb

@@ -176,7 +176,7 @@ def print_variable(name, value, kind)
           CGI.escapeHTML(name), build_compact_value_attr(value, value_str), kind,
           build_value_attr(escaped_value_str), value.class,
           has_children, value.respond_to?(:object_id) ? value.object_id : value.id)
-      print("<value><![CDATA[%s]]></value>", escaped_value_str) if Debugger.rm_protocol_extensions
+      print("<value><![CDATA[%s]]></value>", escaped_value_str) if Debugger.value_as_nested_element
       print('</variable>')
     rescue StandardError => e
       print_debug "Unexpected exception \"%s\"\n%s", e.to_s, e.backtrace.join("\n")
@@ -398,7 +398,7 @@ def safe_to_string(value)
     end
 
     def build_value_attr(escaped_value_str)
-      Debugger.skip_value_attr ? '' : "value=\"#{escaped_value_str}\""
+      Debugger.value_as_nested_element ? '' : "value=\"#{escaped_value_str}\""
     end
 
     instance_methods.each do |m|