Remove deprecated params_builder extensions.

Author: ericproulx

CHANGELOG.md

@@ -12,6 +12,7 @@
 * [#2643](https://github.com/ruby-grape/grape/pull/2638): Remove `try` method in codebase - [@ericproulx](https://github.com/ericproulx).
 * [#2646](https://github.com/ruby-grape/grape/pull/2646): Call `valid_encoding?` before scrub - [@ericproulx](https://github.com/ericproulx).
 * [#2644](https://github.com/ruby-grape/grape/pull/2644): Clean useless/not valuable dependencies - [@ericproulx](https://github.com/ericproulx).
+* [#2648](https://github.com/ruby-grape/grape/pull/2648): Remove deprecated ParamsBuilders extensions - [@ericproulx](https://github.com/ericproulx).
 * Your contribution here.
 
 #### Fixes

UPGRADING.md

@@ -1,6 +1,13 @@
 Upgrading Grape
 ===============
 
+### Upgrading to >= 3.1
+
+#### ParamsBuilder Grape::Extensions
+
+Deprecated [ParamsBuilder's extensions](https://github.com/ruby-grape/grape/blob/master/UPGRADING.md#params-builder) has been removed from the code base.
+
+
 ### Upgrading to >= 3.0.0
 
 #### Ruby 3+ Argument Delegation Modernization

lib/grape.rb

@@ -2,7 +2,6 @@
 
 require 'logger'
 require 'active_support'
-require 'active_support/concern'
 require 'active_support/version'
 require 'active_support/isolated_execution_state'
 require 'active_support/core_ext/array/conversions' # to_xml

lib/grape/extensions/active_support/hash_with_indifferent_access.rb

@@ -4,29 +4,12 @@ module Grape
   module ParamsBuilder
     extend Grape::Util::Registry
 
-    SHORT_NAME_LOOKUP = {
-      'Grape::Extensions::Hash::ParamBuilder' => :hash,
-      'Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder' => :hash_with_indifferent_access,
-      'Grape::Extensions::Hashie::Mash::ParamBuilder' => :hashie_mash
-    }.freeze
-
     module_function
 
     def params_builder_for(short_name)
-      verified_short_name = verify_short_name!(short_name)
-
-      raise Grape::Exceptions::UnknownParamsBuilder, verified_short_name unless registry.key?(verified_short_name)
-
-      registry[verified_short_name]
-    end
-
-    def verify_short_name!(short_name)
-      return short_name if short_name.is_a?(Symbol)
+      raise Grape::Exceptions::UnknownParamsBuilder, short_name unless registry.key?(short_name)
 
-      class_name = short_name.name
-      SHORT_NAME_LOOKUP[class_name].tap do |real_short_name|
-        Grape.deprecator.warn "#{class_name} has been deprecated. Use short name :#{real_short_name} instead."
-      end
+      registry[short_name]
     end
   end
 end

lib/grape/extensions/hash.rb

@@ -5,44 +5,6 @@
 
   let(:app) { Class.new(Grape::API) }
 
-  describe 'Grape::Extensions::Hashie::Mash::ParamBuilder' do
-    describe 'deprecation' do
-      context 'when included' do
-        subject do
-          Class.new(Grape::API) do
-            include Grape::Extensions::Hashie::Mash::ParamBuilder
-          end
-        end
-
-        let(:message) do
-          'This concern has been deprecated. Use `build_with` with one of the following short_name (:hash, :hash_with_indifferent_access, :hashie_mash) instead.'
-        end
-
-        it 'raises a deprecation' do
-          expect(Grape.deprecator).to receive(:warn).with(message).and_raise(ActiveSupport::DeprecationException, :deprecated)
-          expect { subject }.to raise_error(ActiveSupport::DeprecationException, 'deprecated')
-        end
-      end
-
-      context 'when using class name' do
-        let(:app) do
-          Class.new(Grape::API) do
-            params do
-              build_with Grape::Extensions::Hashie::Mash::ParamBuilder
-            end
-            get
-          end
-        end
-
-        it 'raises a deprecation' do
-          expect(Grape.deprecator).to receive(:warn).with('Grape::Extensions::Hashie::Mash::ParamBuilder has been deprecated. Use short name :hashie_mash instead.').and_raise(ActiveSupport::DeprecationException,
-                                                                                                                                                                               :deprecated)
-          expect { get '/' }.to raise_error(ActiveSupport::DeprecationException, 'deprecated')
-        end
-      end
-    end
-  end
-
   describe 'Grape::ParamsBuilder::HashieMash' do
     describe 'in an endpoint' do
       describe '#params' do