clean up jruby support

Author: ajjahn

lib/reactive-ruby/server_rendering/contextual_renderer.rb

@@ -1,11 +1,12 @@
 module ReactiveRuby
   module ServerRendering
-    def self.context_instance_var_name
-      if RUBY_PLATFORM == 'java'
-        '@rhino_context'
-      else
-        '@v8_context'
-      end
+    def self.context_instance_name
+      return '@rhino_context' if RUBY_PLATFORM == 'java'
+      '@v8_context'
+    end
+
+    def self.context_instance_for(context)
+      context.instance_variable_get(context_instance_name)
     end
 
     class ContextualRenderer < React::ServerRendering::SprocketsRenderer
@@ -15,9 +16,9 @@ def initialize(options = {})
       end
 
       def render(component_name, props, prerender_options)
-        if prerender_options.is_a? Hash
+        if prerender_options.is_a?(Hash)
           if v8_runtime? && prerender_options[:context_initializer]
-            raise React::ServerRendering::PrerenderError.new(component_name, props, "you must use 'therubyracer' with the prerender[:context] option") unless v8_runtime?
+            raise PrerenderError.new(component_name, props, "you must use 'therubyracer' with the prerender[:context] option") unless v8_runtime?
           else
             prerender_options[:context_initializer].call v8_context
             prerender_options = prerender_options[:static] ? :static : true
@@ -30,10 +31,11 @@ def render(component_name, props, prerender_options)
       private
 
       def v8_runtime?
-        ExecJS.runtime.name == "(V8)" || ExecJS.runtime.name == "therubyrhino (Rhino)"
+        ["(V8)", "therubyrhino (Rhino)"].include?(ExecJS.runtime.name)
       end
+
       def v8_context
-        @v8_context ||= @context.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name)
+        @v8_context ||= ReactiveRuby::ServerRendering.context_instance_for(@context)
       end
     end
   end

spec/reactive-ruby/component_loader_spec.rb

@@ -10,7 +10,7 @@
 
   let(:js) { ::Rails.application.assets['components'].to_s }
   let(:context) { ExecJS.compile(GLOBAL_WRAPPER + js) }
-  let(:v8_context) { context.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name) }
+  let(:v8_context) { ReactiveRuby::ServerRendering.context_instance_for(context) }
 
   describe '.new' do
     it 'raises a meaningful exception when initialized without a context' do

spec/reactive-ruby/isomorphic_helpers_spec.rb

@@ -73,7 +73,7 @@ def test_context(files = nil)
       end
       js = "#{React::ServerRendering::ExecJSRenderer::GLOBAL_WRAPPER}#{js}"
       ctx = ExecJS.compile(js)
-      ctx = ctx.instance_variable_get(ReactiveRuby::ServerRendering.context_instance_var_name)
+      ctx = ReactiveRuby::ServerRendering.context_instance_for(ctx)
     end
 
     def react_context