Skip to content
This repository was archived by the owner on Oct 19, 2018. It is now read-only.

Commit cdc751d

Browse files
committed
Make v13 test back and skip it at runtime
1 parent fc37df3 commit cdc751d

File tree

3 files changed

+40
-40
lines changed

3 files changed

+40
-40
lines changed

spec/react/component_spec.rb

Lines changed: 32 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -356,39 +356,38 @@ def render
356356
end
357357
end
358358

359-
# deprecated as of React 14
360-
# describe 'Props Updating' do
361-
# before do
362-
# stub_const 'Foo', Class.new
363-
# Foo.class_eval do
364-
# include React::Component
365-
# end
366-
# end
367-
#
368-
# it 'supports original `setProps` as method `set_props`' do
369-
# Foo.class_eval do
370-
# def render
371-
# React.create_element('div') { params[:foo] }
372-
# end
373-
# end
374-
#
375-
# element = renderToDocument(Foo, {foo: 10})
376-
# element.set_props(foo: 20)
377-
# expect(`#{element.dom_node}.innerHTML`).to eq('20')
378-
# end
379-
#
380-
# it 'supports original `replaceProps` as method `set_props!`' do
381-
# Foo.class_eval do
382-
# def render
383-
# React.create_element('div') { params[:foo] ? 'exist' : 'null' }
384-
# end
385-
# end
386-
#
387-
# element = renderToDocument(Foo, {foo: 10})
388-
# element.set_props!(bar: 20)
389-
# expect(element.getDOMNode.innerHTML).to eq('null')
390-
# end
391-
# end
359+
describe 'Props Updating', v13_only: true do
360+
before do
361+
stub_const 'Foo', Class.new
362+
Foo.class_eval do
363+
include React::Component
364+
end
365+
end
366+
367+
it 'supports original `setProps` as method `set_props`' do
368+
Foo.class_eval do
369+
def render
370+
React.create_element('div') { params[:foo] }
371+
end
372+
end
373+
374+
element = renderToDocument(Foo, {foo: 10})
375+
element.set_props(foo: 20)
376+
expect(`#{element.dom_node}.innerHTML`).to eq('20')
377+
end
378+
379+
it 'supports original `replaceProps` as method `set_props!`' do
380+
Foo.class_eval do
381+
def render
382+
React.create_element('div') { params[:foo] ? 'exist' : 'null' }
383+
end
384+
end
385+
386+
element = renderToDocument(Foo, {foo: 10})
387+
element.set_props!(bar: 20)
388+
expect(element.getDOMNode.innerHTML).to eq('null')
389+
end
390+
end
392391

393392
describe 'Prop validation' do
394393
before do

spec/react/react_spec.rb

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,11 @@ def render
142142
end
143143

144144
describe "class_name helpers (React.addons.classSet)" do
145-
146-
# deprecated as of React 14
147-
# it "should transform Hash provided to `class_name` props as string" do
148-
# classes = {foo: true, bar: false, lorem: true}
149-
# element = React.create_element("div", class_name: classes)
150-
# expect(element.props.className).to eq("foo lorem")
151-
# end
145+
it "should transform Hash provided to `class_name` props as string", v13_only: true do
146+
classes = {foo: true, bar: false, lorem: true}
147+
element = React.create_element("div", class_name: classes)
148+
expect(element.props.className).to eq("foo lorem")
149+
end
152150

153151
it "should not alter behavior when passing a string" do
154152
element = React.create_element("div", class_name: "foo bar")

spec/spec_helper.rb

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ def self.should_immediately_generate(opts={}, &block)
7272
RSpec.configure do |config|
7373
config.include React::SpecHelpers
7474
config.filter_run_excluding :ruby
75+
if `(React.version.search(/^0\.13/) === -1)`
76+
config.filter_run_excluding :v13_only
77+
end
7578
end
7679
end
7780

0 commit comments

Comments
 (0)