⬆️ rubocop-lts

- add kettle-soup-cover for code coverage

Author: pboling

.rubocop.yml

@@ -1,19 +1,9 @@
 inherit_from:
-  - .rubocop_todo.yml
   - .rubocop_rspec.yml
 
 inherit_gem:
   rubocop-lts: rubocop-lts.yml
 
-require:
-  # Try adding back once we reach rubocop-ruby2_3+
-  #  - 'rubocop-md'
-  # Can be added once we reach rubocop-ruby2_3+
-  #  - 'rubocop-packaging'
-  - 'rubocop-performance'
-  - 'rubocop-rake'
-  - 'rubocop-rspec'
-
 AllCops:
   DisplayCopNames: true # Display the name of the failing cops
   Exclude:
@@ -38,7 +28,7 @@ Gemspec/RequiredRubyVersion:
 Metrics/BlockNesting:
   Max: 2
 
-Metrics/LineLength:
+Layout/LineLength:
   Enabled: false
 
 Metrics/ParameterLists:
@@ -60,12 +50,6 @@ Lint/UnusedBlockArgument:
     - 'vendor/**/*'
     - '**/.irbrc'
 
-RSpec/DescribeClass:
-  Exclude:
-    - 'spec/examples/*'
-
-RSpec/NestedGroups:
-  Enabled: false
 
 Style/ClassVars:
   Enabled: false

.rubocop_gradual.lock

@@ -1,6 +1,3 @@
-RSpec/FilePath:
-  Enabled: false
-
 RSpec/MultipleExpectations:
   Enabled: false
 
@@ -24,3 +21,8 @@ RSpec/NestedGroups:
 
 RSpec/ExpectInHook:
   Enabled: false
+
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/examples/*'
+

.rubocop_rspec.yml

@@ -1,32 +1,3 @@
-# frozen_string_literal: true
+require "kettle/soup/cover/config"
 
-# To get coverage
-# On Local, default (HTML) output, it just works, coverage is turned on:
-#   bundle exec rspec spec
-# On Local, all output formats:
-#   COVER_ALL=true bundle exec rspec spec
-#
-# On CI, all output formats, the ENV variables CI is always set,
-#   and COVER_ALL, and CI_CODECOV, are set in the coverage.yml workflow only,
-#   so coverage only runs in that workflow, and outputs all formats.
-#
-
-if RUN_COVERAGE
-  SimpleCov.start do
-    enable_coverage :branch
-    primary_coverage :branch
-    add_filter 'spec'
-    add_filter 'lib/oauth2/version.rb'
-    track_files '**/*.rb'
-
-    if ALL_FORMATTERS
-      command_name "#{ENV['GITHUB_WORKFLOW']} Job #{ENV['GITHUB_RUN_ID']}:#{ENV['GITHUB_RUN_NUMBER']}"
-    else
-      formatter SimpleCov::Formatter::HTMLFormatter
-    end
-
-    minimum_coverage(line: 100, branch: 100)
-  end
-else
-  puts "Not running coverage on #{RUBY_ENGINE} #{RUBY_VERSION}"
-end
+SimpleCov.start

.rubocop_todo.yml

@@ -1,58 +1,31 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
-
-gemspec
+source "https://rubygems.org"
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 git_source(:gitlab) { |repo_name| "https://gitlab.com/#{repo_name}" }
 
-gem 'rake', '~> 13.0'
-
-gem 'rspec', '~> 3.0'
-
-ruby_version = Gem::Version.new(RUBY_VERSION)
-minimum_version = ->(version, engine = 'ruby') { ruby_version >= Gem::Version.new(version) && RUBY_ENGINE == engine }
-linting = minimum_version.call('2.7')
-coverage = minimum_version.call('2.7')
-debug = minimum_version.call('2.5')
-
-gem 'overcommit', '~> 0.58' if linting
-
-platforms :mri do
-  if linting
-    # Danger is incompatible with Faraday 2 (for now)
-    # see: https://github.com/danger/danger/issues/1349
-    # gem 'danger', '~> 8.4'
-    # Commented out rubocop-md because of the <--rubocop/md--> bug
-    # gem 'rubocop-md', require: false
-    # Can be added once we reach rubocop-lts >= v10 (i.e. drop Ruby 2.2)
-    # gem 'rubocop-packaging', require: false
-    gem 'rubocop-performance', require: false
-    gem 'rubocop-rake', require: false
-    gem 'rubocop-rspec', require: false
-    gem 'rubocop-thread_safety', require: false
-  end
-  if coverage
-    gem 'codecov', '~> 0.6' # For CodeCov
-    gem 'simplecov', '~> 0.21', require: false
-    gem 'simplecov-cobertura' # XML for Jenkins
-    gem 'simplecov-json' # For CodeClimate
-    gem 'simplecov-lcov', '~> 0.8', require: false
-  end
-  if debug
-    # Add `byebug` to your code where you want to drop to REPL
-    gem 'byebug'
-  end
-end
-platforms :jruby do
-  # Add `binding.pry` to your code where you want to drop to REPL
-  gem 'pry-debugger-jruby'
-end
+#### IMPORTANT #######################################################
+# Gemfile is for local development ONLY; Gemfile is NOT loaded in CI #
+####################################################### IMPORTANT ####
+
+# Include dependencies from <gem name>.gemspec
+gemspec
 
-### deps for documentation and rdoc.info
-group :documentation do
-  gem 'github-markup', platform: :mri
-  gem 'redcarpet', platform: :mri
-  gem 'yard', require: false
+platform :mri do
+  # Use binding.break, binding.b, or debugger in code
+  gem "debug", ">= 1.0.0"                  # ruby >= 2.7
+  gem "gem_bench", "~> 2.0", ">= 2.0.5"
 end
+
+# Security Audit
+eval_gemfile "gemfiles/modular/audit.gemfile"
+
+# Code Coverage
+eval_gemfile "gemfiles/modular/coverage.gemfile"
+
+# Linting
+eval_gemfile "gemfiles/modular/style.gemfile"
+
+# Documentation
+eval_gemfile "gemfiles/modular/documentation.gemfile"