Skip to content

Commit ada5ca9

Browse files
authored
Merge pull request #464 from eregon/truffleruby-benchmark-ci
Remove continue-on-error for benchmarks in CI
2 parents cc0335f + 6016b63 commit ada5ca9

File tree

1 file changed

+11
-3
lines changed

1 file changed

+11
-3
lines changed

.github/workflows/test.yml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,16 @@ jobs:
4343
strategy:
4444
fail-fast: false
4545
matrix:
46-
ruby: [ruby, head, truffleruby]
46+
include:
47+
- ruby: ruby
48+
- ruby: head
49+
- ruby: truffleruby
50+
# knucleotide: needs fork
51+
# lobsters: commonmarker fails to install
52+
# railsbench: NoMethodError: undefined method `[]=' for class Fiber (NoMethodError)
53+
# ruby-lsp: rbs_extension.so: undefined symbol: ruby_vm_at_exit
54+
# shipit: cannot load such file -- pty
55+
extra_args: "--excludes=knucleotide,lobsters,railsbench,ruby-lsp,shipit"
4756
if: ${{ github.event_name != 'schedule' || github.repository == 'ruby/ruby-bench' }}
4857
steps:
4958
- uses: actions/checkout@v3
@@ -53,12 +62,11 @@ jobs:
5362
ruby-version: ${{ matrix.ruby }}
5463

5564
- name: Test run_benchmarks.rb
56-
run: ./run_benchmarks.rb
65+
run: ./run_benchmarks.rb ${{ matrix.extra_args }}
5766
env:
5867
WARMUP_ITRS: '1'
5968
MIN_BENCH_ITRS: '1'
6069
MIN_BENCH_TIME: '0'
61-
continue-on-error: ${{ matrix.ruby == 'truffleruby' }}
6270

6371
benchmark-ractor:
6472
runs-on: ubuntu-latest

0 commit comments

Comments
 (0)