Rollup of 4 pull requests #149701
Merged
Rollup of 4 pull requests #149701
+869
−771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the rust-version file to d3e1ccd.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: d3e1ccd Filtered ref: de0859194683d26da60d5d81db7f1f2a143b591d Upstream diff: rust-lang/rust@cc328c1...d3e1ccd This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
Updated link from SUMMARY.md to README.md in ui.md
Fix link to README in ui test documentation
Added a reference to The Rust Book for more information on Rust's release channels.
Update contributing.md with Rust Book reference
add a high-level design description
Give an overview of our stability guarantees
This updates the rust-version file to 1be6b13.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 1be6b13 Filtered ref: c2f66d57037ceb012cfd97c83feff7e7edb7dd40 Upstream diff: rust-lang/rust@d3e1ccd...1be6b13 This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
There was an issue raised that the toolchain explanation for building and running the compiler needed some refinement. This patch aims to remedy that by specifying what "first" and "second" refer to, and what the toolchain does. Small change to the language to specify that the stage2 toolchain is not built, and how one would build it.
Co-authored-by: Tshepang Mbambo <hopsi@tuta.io>
Fix rust-lang#1737: Specify toolchain part in building and running
`P` was removed in rust-lang#145146 (replaced with plain Box). `CrateLoader` was inlined to `CStore` in rust-lang#144059. `elaborate_drops.rs` was moved in rust-lang#137008.
Fix some broken links
Update to mdbook 0.5
sembr backend/libs-and-metadata.md
sembr tests/crater.md
This updates the rust-version file to dfe1b8c.
Add Zed to quickstart
f*::min/max: fix comparing with libm and IEEE operations What we document actually doesn't match what libm does any more, libm got "fixed"/changed in https://sourceware.org/bugzilla/show_bug.cgi?id=20947. So better remove the remark. Instead, explicitly call out that this is a mix of `minNum` and `minimumNumber`. Also fix the intrinsics which incorrectly claimed to be like `minNum`, but their intended SNaN behavior is actually different from that. r? `@tgross35`
…_fn, r=fee1-dead `is_const_default_method` is completely handled by the `constness` query After rust-lang#149444 this function became obsolete r? `@fee1-dead`
…nszelmann Move attribute lints to `rustc_lint` This PR changes two things: - This decouples the `AttributeLintKind` from the `Lint` it is emitted in. `cx.emit_lint` now takes both as an argument, rather than inferring the `Lint` from the `AttributeLintKind`. This is nice because: - It allows us to remove `AttributeLintKind::InvalidMacroExportArguments` - It allows us to move the choice between `USELESS_DEPRECATED` and `UNUSED_ATTRIBUTES` out of the lint emitting code - It allows the next change: - This moves `AttributeLintKind` to `rustc_lint_defs`, and the decorating code to `rustc_lint`. This is nice because: - It allows attribute lint decorating code to access the TypeCtxt, which unblocks rust-lang#149215 - It might allow most early buffered attribute lints to become dyn lint diagnostics in the future, as in rust-lang#147634 - It deduplicates `IllFormedAttributeInput` This PR does not change observable output of the compiler, as can be seen by no uitests being affected. r? `@jdonszelmann`
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@0afee7b. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
rustbot
added
A-attributes
Member
Author
|
@bors r+ rollup=never p=4 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: b4f1098e10 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing b4f1098 (parent) -> fbab541 (this PR) Test differencesShow 689 test diffsStage 0
Stage 1
(and 50 additional test diffs) Additionally, 539 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard fbab541a7ad1c22fc51783d03c7d75fa577f5633 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (fbab541): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.8%, secondary -3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.8%, secondary 4.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 471.737s -> 471.701s (-0.01%) |
This was referenced Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_const_default_methodis completely handled by theconstnessquery #149592 (is_const_default_methodis completely handled by theconstnessquery)rustc_lint#149662 (Move attribute lints torustc_lint)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup