Merge pull request #286 from fox0/clippy--assertions_on_constants

Fix clippy::needless_range_loop, op_ref,assertions_on_constants, and add one test

Author: jgarzik

file/split.rs

@@ -151,11 +151,8 @@ impl OutputState {
 
     fn write(&mut self, buf: &[u8]) -> io::Result<()> {
         match &mut self.outf {
-            None => {
-                assert!(false);
-                Ok(())
-            }
             Some(ref mut f) => f.write_all(buf),
+            None => Ok(()),
         }
     }
 

text/sort.rs

@@ -945,19 +945,26 @@ fn merge_files(paths: &mut Vec<Box<dyn Read>>, output_path: &Option<PathBuf>) ->
 ///
 /// A vector of strings (`Vec<String>`) where consecutive empty strings are merged with the nearest non-empty string.
 ///
+/// # Examples
+///
+/// ```
+/// let result = merge_empty_lines(vec!["line1", "line2", "", "", "", "lineN"]);
+/// assert_eq!(result, vec!["line1", "line2", "   lineN"]);
+/// ```
+///
 fn merge_empty_lines(vec: Vec<&str>) -> Vec<String> {
     let mut empty_count = 0;
     let mut result = vec![];
 
-    for i in 0..vec.len() {
-        if vec[i].is_empty() {
+    for i in vec {
+        if i.is_empty() {
             empty_count += 1;
         } else if empty_count > 0 {
             let spaces = " ".repeat(empty_count);
-            result.push(format!("{}{}", spaces, vec[i]));
+            result.push(format!("{}{}", spaces, i));
             empty_count = 0;
         } else {
-            result.push(vec[i].to_string());
+            result.push(i.to_string());
         }
     }
 
@@ -1029,3 +1036,14 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     std::process::exit(exit_code)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_merge_empty_lines() {
+        let result = merge_empty_lines(vec!["line1", "line2", "", "", "", "lineN"]);
+        assert_eq!(result, vec!["line1", "line2", "   lineN"]);
+    }
+}

tree/ls.rs

@@ -1228,7 +1228,7 @@ fn process_single_dir(
             let dir_parent = {
                 let mut comps = canonical_dir_path.as_inner().components();
 
-                let is_dot = dir_entry.file_name().to_bytes_with_nul() == &[b'.', 0];
+                let is_dot = dir_entry.file_name().to_bytes_with_nul() == [b'.', 0];
 
                 if !is_dot {
                     comps.next_back();