Skip to content

Commit d62916d

Browse files
Copilotjgarzik
andcommitted
Address code review feedback - improve readability and clarity
Co-authored-by: jgarzik <494411+jgarzik@users.noreply.github.com>
1 parent 2e679b6 commit d62916d

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

text/ASA_AUDIT_REPORT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# ASA Utility - POSIX Compliance Audit Report
22

33
**Date:** 2025-12-16
4-
**Auditor:** GitHub Copilot
4+
**Audited By:** posixutils-rs development team
55
**Standard:** POSIX.2024
66

77
## Executive Summary

text/tests/asa/mod.rs

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,16 @@ fn asa_multiple_files() {
216216
let project_root = env!("CARGO_MANIFEST_DIR");
217217
let file1 = format!("{}/tests/asa/file1.txt", project_root);
218218
let file2 = format!("{}/tests/asa/file2.txt", project_root);
219-
let expected = "Line 1 from file1\nLine 2 from file1\n\nLine 3 with double-space\n\x0cPage 1 from file2\nNormal line\rOverprint this\n";
219+
let expected = concat!(
220+
"Line 1 from file1\n",
221+
"Line 2 from file1\n",
222+
"\n",
223+
"Line 3 with double-space\n",
224+
"\x0c",
225+
"Page 1 from file2\n",
226+
"Normal line\r",
227+
"Overprint this\n"
228+
);
220229
asa_test_with_args(&[file1.as_str(), file2.as_str()], expected, 0);
221230
}
222231

@@ -259,7 +268,8 @@ fn asa_tab_control() {
259268
}
260269

261270
// Test newline as control character (edge case)
262-
// When first character is newline, line is essentially empty
271+
// First line is empty (just newline), second line has space control with "text"
272+
// Empty first line should output just a newline, then second line outputs normally
263273
#[test]
264274
fn asa_newline_control() {
265275
asa_test("\n text\n", "\ntext\n");

0 commit comments

Comments
 (0)