Remove mention of patchbot, remove 'make buildbot-python3'

Author: Matthias Koeppe

Makefile

@@ -78,14 +78,6 @@ reconfigure:
 	        exit 1; \
 	fi
 
-# This is used to monitor progress towards Python 3 and prevent
-# regressions. Should be removed after the full switch to python3.
-#
-# As of Sage 9.0: keep the build target for backward compatibility,
-# but it just runs "make".
-buildbot-python3:
-	$(MAKE)
-
 # Preemptively download all source tarballs of normal packages.
 download:
 	export SAGE_ROOT=$$(pwd) && \
@@ -376,5 +368,5 @@ list:
 	misc-clean bdist-clean distclean bootstrap-clean maintainer-clean \
 	test check testoptional testall testlong testoptionallong testallong \
 	ptest ptestoptional ptestall ptestlong ptestoptionallong ptestallong \
-	buildbot-python3 list \
+	list \
 	doc-clean clean sagelib-clean build-clean

src/.relint.yml

@@ -1,7 +1,4 @@
-# From https://github.com/sagemath/sage-patchbot/blob/master/sage_patchbot/plugins.py
-# (simple pattern-exclusion plugins)
-# The patterns have been edited slightly because relint tests the regexp to the whole file,
-# whereas the patchbots tests them line by line.
+# Simple pattern exclusions
 
 - name: 'python3: Python3 incompatible code'
   hint: |

src/bin/sage

@@ -193,29 +193,6 @@ if [ "$1" = '--nodotsage' ]; then
     exit $status
 fi
 
-# Check for '--patchbot' before sourcing sage-env: patchbot needs
-# an unclobbered environment before testing unsafe tickets.
-if [ "$1" = '-patchbot' -o "$1" = "--patchbot" ]; then
-    shift
-    # We ask the Python from Sage where the patchbot is installed.
-    # We set PYTHONPATH to that directory such that the system Python
-    # should also find the sage_patchbot package.
-    cmd='import sage_patchbot as p; import os; print(os.path.dirname(p.__path__[0]))'
-    export PYTHONPATH=`"$SAGE_ROOT/sage" --python3 -c "$cmd"`
-    if [ -z "$PYTHONPATH" ]; then
-        # Something went wrong, assume that the patchbot is not installed
-        echo >&2 "Error: cannot find installation path for sage_patchbot"
-        echo >&2 "See https://wiki.sagemath.org/buildbot for instructions"
-        exit 1
-    fi
-
-    shopt -s execfail  # Do not exit if "exec" fails
-    exec python3 -m sage_patchbot.patchbot "$@"
-    echo >&2 "Error: cannot find a suitable Python 3 program."
-    echo >&2 "The SageMath patchbot requires a system Python 3 installation."
-    exit 127
-fi
-
 # Check for '-i' etc. before sourcing sage-env: running "make"
 # should be run outside of the Sage shell.
 case "$1" in

src/doc/en/developer/tools.rst

@@ -58,7 +58,6 @@ available::
                                   (same as "sage --startuptime")
         pycodestyle-minimal    -- check against Sage's minimal style conventions
         relint                 -- check whether some forbidden patterns appear
-                                  (includes all patchbot pattern-exclusion plugins)
         codespell              -- check for misspelled words in source code
         rst                    -- validate Python docstrings markup as reStructuredText
         coverage.py            -- run the Sage doctester with Coverage.py
@@ -180,9 +179,7 @@ As of Sage 9.5, the entire Sage library conforms to this configuration::
     congratulations :)
 
 When preparing a branch for a Sage ticket, developers should verify that ``./sage -tox -e
-pycodestyle-minimal`` passes.  When the Sage patchbot runs on the ticket, it will perform similar
-coding style checks; but running the check locally reduces the turnaround time from hours
-to seconds.
+pycodestyle-minimal`` passes.
 
 The second configuration is used with the command ``./sage -tox -e pycodestyle`` and runs a
 more thorough check::

src/tox.ini

@@ -172,7 +172,6 @@ statistics = True
 [testenv:relint]
 description =
     check whether some forbidden patterns appear
-    (includes all patchbot pattern-exclusion plugins)
 # https://github.com/codingjoe/relint
 # The patterns are in .relint.yml
 deps = relint

tox.ini

@@ -1033,7 +1033,7 @@ allowlist_externals = {[sage_src]allowlist_externals}
 
 [testenv:relint]
 description =
-    check whether some forbidden patterns appear - similar to patchbot plugins
+    check whether some forbidden patterns appear
 passenv  = {[sage_src]passenv}
 envdir   = {[sage_src]envdir}
 commands = {[sage_src]commands}