Commit cf58964
Release Manager
gh-37630: Enhance documentation of Drinfeld module Potemine j-invariants
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes #12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes #12345". -->
The definition of $j$-invariants, *basic* $j$-invariants and
$j_k$-invariants defer in [Potemine's
article](https://link.springer.com/article/10.1023/A:1009724323513) and
[Papikian's
book](https://link.springer.com/book/10.1007/978-3-031-19707-9). Thanks
to @DavidAyotte, we follow Potemine's convention. Seeing however the
growing popularity of Papikian's book, I reckon it is a good idea to add
a note in the documentation addressing those differences.
Also, I fixed a typo.
### Potemine:


### Papikian:


### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - #12345: short description why this is a dependency -->
<!-- - #34567: ... -->
URL: #37630
Reported by: Antoine Leudière
Reviewer(s): David AyotteFile tree
4 files changed
+29
-10
lines changed- build/pkgs/configure
- src
- doc/en/reference/references
- sage/rings/function_field/drinfeld_modules
4 files changed
+29
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5133 | 5133 | | |
5134 | 5134 | | |
5135 | 5135 | | |
| 5136 | + | |
| 5137 | + | |
| 5138 | + | |
| 5139 | + | |
5136 | 5140 | | |
5137 | 5141 | | |
5138 | 5142 | | |
| |||
Lines changed: 21 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1489 | 1489 | | |
1490 | 1490 | | |
1491 | 1491 | | |
1492 | | - | |
| 1492 | + | |
1493 | 1493 | | |
1494 | 1494 | | |
1495 | 1495 | | |
| |||
1510 | 1510 | | |
1511 | 1511 | | |
1512 | 1512 | | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
1513 | 1533 | | |
1514 | 1534 | | |
1515 | 1535 | | |
| |||
1536 | 1556 | | |
1537 | 1557 | | |
1538 | 1558 | | |
1539 | | - | |
1540 | | - | |
1541 | | - | |
1542 | | - | |
1543 | | - | |
1544 | 1559 | | |
1545 | 1560 | | |
1546 | 1561 | | |
| |||
0 commit comments