src/bin/sage-env: Do not set the ld-classic flag when LD is set

Author: Matthias Koeppe

src/bin/sage-env

@@ -127,7 +127,7 @@ fi
 # The compilers are set in order of priority by
 # 1) environment variables
 # 2) compiler installed by sage
-# 3) compiler set at configuration time 
+# 3) compiler set at configuration time
 if [ -z "$CC" ]; then
     if [ -n "$SAGE_LOCAL" -a -x "$SAGE_LOCAL/bin/gcc" ]; then
         CC=gcc
@@ -378,7 +378,9 @@ if [ -n "$SAGE_LOCAL" ]; then
     # gives "/Applications/Xcode.app/Contents/Developer", but "ld-classic"
     # is not in the subdirectory "usr/bin/" but rather in the subdirectory
     # "Toolchains/XcodeDefault.xctoolchain/usr/bin/". See #37237.
-    if [ "$UNAME" = "Darwin" ] && [ -x "$(xcode-select -p)/usr/bin/ld-classic" -o -x "$(xcode-select -p)/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld-classic" ] ; then
+    # However, if LD is set explicitly, as it is within conda on macOS,
+    # do not not do this.
+    if [ "$UNAME" = "Darwin" ] && [ -z "$LD" ] && [ -x "$(xcode-select -p)/usr/bin/ld-classic" -o -x "$(xcode-select -p)/Toolchains/XcodeDefault.xctoolchain/usr/bin/ld-classic" ] ; then
         LDFLAGS="-L$SAGE_LOCAL/lib -Wl,-ld_classic,-rpath,$SAGE_LOCAL/lib $LDFLAGS"
     else
         LDFLAGS="-L$SAGE_LOCAL/lib -Wl,-rpath,$SAGE_LOCAL/lib $LDFLAGS"