gh-37391: Make installation of "wheel" packages less noisy
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Some care for `build/bin/sage-spkg`, reducing unhelpful verbosity. In
particular, for "wheel" packages (https://deploy-livedoc--
sagemath.netlify.app/html/en/developer/packaging#package-source-types),
there is no build step, so there is no point in talking about what C
compiler is in use.

Also saving a few lines of output (and making it clearer who does what)
by prefixing the output from the various `spkg-...` scripts.

Example:
```
$ make packaging-no-deps
[packaging-23.2] Using cached file /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/upstream/packaging-23.2-py3-none-any.whl
[packaging-23.2] Setting up build directory /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/local/var/lib/sage/venv-
python3.11/var/tmp/sage/build/packaging-23.2
[packaging-23.2] [spkg-piprm] Found existing installation: packaging
23.2
[packaging-23.2] [spkg-piprm] Uninstalling packaging-23.2:
[packaging-23.2] [spkg-piprm]   Successfully uninstalled packaging-23.2
[packaging-23.2] Removing stamp file /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/local/var/lib/sage/venv-
python3.11/var/lib/sage/installed/packaging-23.2
[packaging-23.2] [spkg-install] Staged wheel file, staged
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-
python3.11/var/lib/sage/scripts/packaging/spkg-requirements.txt
[packaging-23.2] Moving package files from temporary location
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-
python3.11/var/tmp/sage/build/packaging-23.2/inst to
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-python3.11
[packaging-23.2] [spkg-pipinst] Using pip 23.3.1 from
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-python3.11/lib/python3.11/site-
packages/pip (python 3.11)
[packaging-23.2] [spkg-pipinst] Looking in links:
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-python3.11/var/lib/sage/wheels
[packaging-23.2] [spkg-pipinst] Processing /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/local/var/lib/sage/venv-
python3.11/var/lib/sage/wheels/packaging-23.2-py3-none-any.whl (from -r
/Users/mkoeppe/s/sage/sage-rebasing/worktree-
pristine/local/var/lib/sage/venv-
python3.11/var/lib/sage/scripts/packaging/spkg-requirements.txt (line
1))
[packaging-23.2] [spkg-pipinst] Installing collected packages: packaging
[packaging-23.2] [spkg-pipinst] ERROR: pip's dependency resolver does
not currently take into account all the packages that are installed.
This behaviour is the source of the following dependency conflicts.
[packaging-23.2] [spkg-pipinst] meson-python 0.15.0 requires
meson>=0.63.3; python_version < "3.12", which is not installed.
[packaging-23.2] [spkg-pipinst] tox 4.11.1 requires cachetools>=5.3.1,
which is not installed.
[packaging-23.2] [spkg-pipinst] tox 4.11.1 requires chardet>=5.2, which
is not installed.
[packaging-23.2] [spkg-pipinst] Successfully installed packaging-23.2
[packaging-23.2] Deleting build directory /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/local/var/lib/sage/venv-
python3.11/var/tmp/sage/build/packaging-23.2
[packaging-23.2] Finished installing packaging-23.2
```

Also displaying build times for each package, even when using `make
V=0`, but suppressing very short build times:
```
$ make V=0
...
[setuptools_scm-8.0.4] installing. Log file: /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/logs/pkgs/setuptools_scm-8.0.4.log
[hatchling-1.20.0] installing. Log file: /Users/mkoeppe/s/sage/sage-
rebasing/worktree-pristine/logs/pkgs/hatchling-1.20.0.log
  [setuptools_scm-8.0.4] successfully installed.
  [hatchling-1.20.0] successfully installed.
...
  [sage_conf-10.3.beta8] successfully installed (real 11.36 user 8.32
sys 2.67).
  [pyproject_metadata-0.7.1] successfully installed (real 16.57 user
10.70 sys 2.97).
  [ipykernel-6.27.1] successfully installed (real 19.31 user 11.35 sys
3.71).
```

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #37391
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee

Author: Release Manager

build/bin/sage-dist-helpers

@@ -323,8 +323,13 @@ sdh_store_wheel() {
         wheel_basename="${wheel##*/}"
         distname="${wheel_basename%%-*}"
         # Record name and wheel file location
+        if [ -n "$SAGE_DESTDIR" ]; then
+            echo "Staged wheel file, staged ${SAGE_SPKG_SCRIPTS}/${PKG_BASE}/spkg-requirements.txt"
+        else
+            echo "Copied wheel file, wrote ${SAGE_SPKG_SCRIPTS}/${PKG_BASE}/spkg-requirements.txt"
+        fi
         mkdir -p ${SAGE_DESTDIR}${SAGE_SPKG_SCRIPTS}/${PKG_BASE}
-        echo "${distname} @ file://${wheel}" >> ${SAGE_DESTDIR}${SAGE_SPKG_SCRIPTS}/${PKG_BASE}/spkg-requirements.txt
+        echo "${distname} @ file://${wheel}" >> "${SAGE_DESTDIR}${SAGE_SPKG_SCRIPTS}/${PKG_BASE}/spkg-requirements.txt"
     fi
     wheel="${SAGE_DESTDIR}${wheel}"
 }
@@ -392,7 +397,7 @@ sdh_actually_pip_install_wheel() {
     # of sage-conf, sage-setup, etc.) bump the version number, we need to
     # override this behavior.  The pip install option --force-reinstall does too
     # much -- it also reinstalls all dependencies, which we do not want.
-    $sudo sage-pip-uninstall "$distname"
+    $sudo sage-pip-uninstall "$distname" 2>&1 | sed '/^WARNING: Skipping .* as it is not installed./d'
     if [ $? -ne 0 ]; then
         echo "(ignoring error)" >&2
     fi

build/bin/sage-logger

@@ -61,6 +61,25 @@ else
     SED=cat
 fi
 
+timefile="$logdir/$logname.time"
+rm -f "$timefile"
+if /usr/bin/time -h -o /dev/null true; then
+    TIME="/usr/bin/time -h -o $timefile"
+else
+    TIME=""
+fi
+
+report_time ()
+{
+    time=$(echo $(cat $timefile))
+    case "$time" in
+        *m*real*|*h*real*|*[1-9][0-9].*real*|*[1-9][0-9],*real*)
+            # at least 10 seconds wall time
+            echo "$time"
+            ;;
+    esac
+}
+
 mkdir -p "$logdir"
 
 # Do all logging of child processes with V=1 to ensure that no
@@ -75,22 +94,30 @@ if [ -n "$SAGE_SILENT_BUILD" -a ${use_prefix} = true ]; then
     # Silent build.
     # Similar to https://www.gnu.org/software/automake/manual/html_node/Automake-Silent-Rules.html#Automake-Silent-Rules
     echo "[$logname] installing. Log file: $logfile"
-    ( exec>> $logfile 2>&1 ; eval "$cmd" )
+    ( exec>> $logfile 2>&1 ; $TIME sh -c "$cmd"; status=$?;
+      [ -r $timefile ] && cat $timefile; exit $status )
     status=$?
     if [[ $status != 0 ]]; then
         echo "  [$logname] error installing, exit status $status. End of log file:"
         tail -n 120 "$logfile" | sed "/Please email sage-devel/,$ d;s;^;  [$logname]   ;" >&2
         echo "  [$logname] Full log file: $logfile"
     else
-        echo "  [$logname] successfully installed."
+        time=$(report_time)
+        if [ -n "$time" ]; then
+            echo "  [$logname] successfully installed ($time)."
+        else
+            echo "  [$logname] successfully installed."
+        fi
     fi
     exit $status
 else
     # Redirect stdout and stderr to a subprocess running tee.
     # We trap SIGINT such that SIGINT interrupts the main process being
     # run, not the logging.
 
-    ( exec 2>&1; eval "$cmd" ) | \
+    ( exec 2>&1;
+      $TIME sh -c "$cmd"; status=$?; report_time;
+      exit $status ) | \
         ( trap '' SIGINT; if [ -n "$GITHUB_ACTIONS" -a -n "$prefix" ]; then echo "::group::${logname}"; fi; tee -a "$logfile" | $SED; if [ -n "$GITHUB_ACTIONS" -a -n "$prefix" ]; then echo "::endgroup::"; fi )
 
     pipestatus=(${PIPESTATUS[*]})

build/bin/sage-spkg

@@ -84,8 +84,8 @@ Modes of operation (provide at most one):
    -x, --check-only: exclusively run the test suite;
        this may assume that:
         * the package has been installed already and/or that
-        * the temporary build directory has not been deleted
-   -e, --erase-build-directory-only: erase (delete) the temporary
+        * the build directory has not been deleted
+   -e, --erase-build-directory-only: erase (delete) the
        build directory only
    --info: print information on the package only
    --help: print this help only
@@ -103,7 +103,7 @@ Other options:
        exit with an error on test suite failures
    -w: after installing, run the test suite for the package;
        print a warning on test suite failures
-   -s: save (do not delete) the temporary build directory,
+   -s: save (do not delete) the build directory,
        even when the installation was successful
 EOF
 }
@@ -451,9 +451,6 @@ if [ ! -w "$SAGE_INST_LOCAL" ]; then
     exit 1
 fi
 
-echo "$PKG_NAME"
-echo "===================================================="
-
 # Make absolutely sure that we are in the build directory before doing
 # a scary "rm -rf" below.
 cd "$SAGE_BUILD_DIR" || exit $?
@@ -483,7 +480,7 @@ fi
 extract_the_package() { ##########################################
 
 cd "$SAGE_BUILD_DIR" || exit $?
-echo "Setting up build directory for $PKG_NAME"
+echo "Setting up build directory $SAGE_BUILD_DIR/$PKG_NAME"
 if [ -z "$PKG_NAME_UPSTREAM" ]; then
     # Not a normal or wheel package.
     # Transplant the 'src' symlink, copy scripts.
@@ -521,7 +518,6 @@ else
             error_msg "Error: failed to extract $PKG_SRC"
             exit 1
         fi
-        echo "Finished extraction"
         cd src
         if ! sage-apply-patches; then
             error_msg "Error applying patches"
@@ -646,14 +642,15 @@ done
 
 actually_build_and_install() { ###################################
 
-echo "****************************************************"
-echo "Host system:"
-uname -a
-echo "****************************************************"
-echo "C compiler: $CC"
-echo "C compiler version:"
-$CC -v
-echo "****************************************************"
+case "$PKG_SRC" in
+    *.whl)
+        # Silence is golden.
+        ;;
+    *)
+        echo "Host system: $(uname -a)"
+        echo "C compiler: $CC$($CC -v 2>&1 | while read -r line; do echo -n ", $line"; done)"
+        ;;
+esac
 
 # Poison the proxy variable to forbid downloads in spkg-install
 # for normal packages
@@ -665,19 +662,21 @@ if [ -n "$PKG_NAME_UPSTREAM" ]; then
     export rsync_proxy=$http_proxy
 fi
 
+# Make sage-logger show the full logs
+unset SAGE_SILENT_BUILD
+unset V
 
 # First uninstall the previous version of this package, if any
 if [ "$KEEP_EXISTING" != "yes" ]; then
-    sage-spkg-uninstall "$PKG_BASE" "$SAGE_INST_LOCAL"
+    sage-spkg-uninstall "$PKG_BASE" "$SAGE_INST_LOCAL" --log-directory .
 fi
 
 # To work around #26996: Create lib and set a symlink so that writes into lib64/ end up in lib/
 (mkdir -p "$SAGE_DESTDIR_LOCAL/lib" && cd "$SAGE_DESTDIR_LOCAL" && ln -sf lib lib64)
 
 # Run the pre-install script, if any
 if [ -f spkg-preinst ]; then
-    echo "Running pre-install script for $PKG_NAME."
-    time $SAGE_SUDO ./spkg-preinst
+    sage-logger -p "$SAGE_SUDO ./spkg-preinst" spkg-preinst.log
     if [ $? -ne 0 ]; then
         error_msg "Error running the preinst script for $PKG_NAME."
         exit 1
@@ -686,19 +685,19 @@ fi
 
 if [ -f spkg-build ]; then
     # Package has both spkg-build and spkg-install; execute the latter with SAGE_SUDO
-    time ./spkg-build
+    sage-logger -p "./spkg-build" spkg-build.log
     if [ $? -ne 0 ]; then
         error_msg "Error building package $PKG_NAME" "make"
         exit 1
     fi
-    time $SAGE_SUDO ./spkg-install
+    sage-logger -p "$SAGE_SUDO ./spkg-install" spkg-install.log
     if [ $? -ne 0 ]; then
         error_msg "Error installing package $PKG_NAME" "make"
         exit 1
     fi
 else
     # Package only has spkg-install
-    time ./spkg-install
+    sage-logger -p "./spkg-install" spkg-install.log
     if [ $? -ne 0 ]; then
         error_msg "Error installing package $PKG_NAME" "make"
         exit 1
@@ -784,16 +783,14 @@ post_install() { #################################################
 # Run the post-install script, if any
 # But first complete the delayed installation of wheels.
 if [ -f spkg-pipinst ]; then
-    echo "Running pip-install script for $PKG_NAME."
-    $SAGE_SUDO ./spkg-pipinst
+    sage-logger -p "$SAGE_SUDO ./spkg-pipinst" spkg-pipinst.log
     if [ $? -ne 0 ]; then
         error_msg "Error running the pipinst script for $PKG_NAME."
         exit 1
     fi
 fi
 if [ -f spkg-postinst ]; then
-    echo "Running post-install script for $PKG_NAME."
-    time $SAGE_SUDO ./spkg-postinst
+    sage-logger -p "$SAGE_SUDO ./spkg-postinst" spkg-postinst.log
     if [ $? -ne 0 ]; then
         error_msg "Error running the postinst script for $PKG_NAME."
         exit 1
@@ -813,7 +810,7 @@ run_test_suite() { ###############################################
     if [ -f "$INSTALLED_SCRIPTS_DEST"/spkg-check ]; then
         echo "Running the test suite for $PKG_NAME..."
         export PKG_BASE
-        time "$INSTALLED_SCRIPTS_DEST"/spkg-check
+        sage-logger -p "$INSTALLED_SCRIPTS_DEST"/spkg-check spkg-check.log
         if [ $? -ne 0 ]; then
             TEST_SUITE_RESULT="failed"
             if [ "$SAGE_CHECK" = "warn" ]; then
@@ -869,8 +866,7 @@ __EOF__
 } ###################################### write_installation_record
 
 delete_the_temporary_build_directory() { #########################
-    echo "Deleting temporary build directory"
-    echo "$SAGE_BUILD_DIR/$PKG_NAME"
+    echo "Deleting build directory $SAGE_BUILD_DIR/$PKG_NAME"
     # On Solaris, the current working directory cannot be deleted,
     # so we "cd" out of $SAGE_BUILD_DIR/$PKG_NAME. See #12637.
     cd "$SAGE_BUILD_DIR"
@@ -881,8 +877,7 @@ delete_the_temporary_build_directory_if_required() { #############
 if [ ! -e "$SAGE_BUILD_DIR/$PKG_NAME/.keep" ]; then
     delete_the_temporary_build_directory
 else
-    echo "You can safely delete the temporary build directory"
-    echo "$SAGE_BUILD_DIR/$PKG_NAME"
+    echo "You can safely delete the build directory $SAGE_BUILD_DIR/$PKG_NAME"
 fi
 } ############### delete_the_temporary_build_directory_if_required
 
@@ -929,7 +924,6 @@ fi
 
 if [ $POST_INSTALL = 1 ]; then
     write_installation_record
-    echo "Successfully installed $PKG_NAME"
     delete_the_temporary_build_directory_if_required
     echo "Finished installing $PKG_NAME"
 fi

build/make/install

@@ -103,7 +103,7 @@ EOF
 ###############################################################################
 # NOW do the actual build:
 ###############################################################################
-time $MAKE "$@"
+$MAKE "$@"
 if [ $? -ne 0 ]; then
     cat >&2 <<EOF
 ***************************************************************

build/pkgs/sagelib/spkg-install.in

@@ -53,7 +53,7 @@ if [ "$SAGE_EDITABLE" = yes ]; then
     (cd "$SITEPACKAGESDIR" && rm -rf sage sage-[1-9]*.egg-info sage-[1-9]*.dist-info)
     # Until https://github.com/sagemath/sage/issues/34209 switches us to PEP 660 editable wheels
     export SETUPTOOLS_ENABLE_FEATURES=legacy-editable
-    time sdh_pip_editable_install .
+    sdh_pip_editable_install .
 
     if [ "$SAGE_WHEELS" = yes ]; then
         # Additionally build a wheel (for use in other venvs)
@@ -69,10 +69,10 @@ else
     if [ "$SAGE_WHEELS" = yes ]; then
         # Use --no-build-isolation to avoid rebuilds because of dependencies:
         # Compiling sage/interfaces/sagespawn.pyx because it depends on /private/var/folders/38/wnh4gf1552g_crsjnv2vmmww0000gp/T/pip-build-env-609n5985/overlay/lib/python3.10/site-packages/Cython/Includes/posix/unistd.pxd
-        time sdh_pip_install --no-build-isolation .
+        sdh_pip_install --no-build-isolation .
     else
         SAGE_OPTIONAL_PACKAGES_WITH_EXTENSIONS+="mcqd,tdlib,coxeter3,sirocco,meataxe,bliss"
-        time python3 -u setup.py --no-user-cfg build install || exit 1
+        python3 -u setup.py --no-user-cfg build install || exit 1
     fi
 fi