Skip to content

params are not passed back into self.hit_ when authentication is required again or rate limit hit #4

@james-gre

Description

@james-gre

Heya,

Thanks for this helpful API ❤️

I feel like I may be missing something here, but when a rate limit is hit or authentication is required, the params arg is forgotten and not passed back into self.hit_

        elif status_code == 401:
            self._authenticate()
            for item in self.hit_(endpoint, method, resource_id, data):
                yield item
        elif status_code == 429:
            self._handle_rate_limit_exceeded()
            for item in self.hit_(endpoint, method, resource_id, data):
                yield item
        else:

Should be for item in self.hit_(endpoint, method, resource_id, data, params): no?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions