Test message re-ordering fixes

Author: danielmillerp

examples/tutorials/00_sync/010_multiturn/tests/test_agent.py

@@ -19,7 +19,7 @@
 import os
 
 import pytest
-from test_utils.sync import validate_text_in_string, collect_streaming_response
+from test_utils.sync import validate_text_in_string, collect_streaming_response, validate_message_ordering
 
 from agentex import Agentex
 from agentex.types import TextContent, TextContentParam
@@ -101,6 +101,9 @@ def test_send_message(self, client: Agentex, agent_name: str, agent_id: str):
             )
             assert len(message_history) == (i + 1) * 2  # user + agent messages
 
+            # Validate messages are in chronological order (oldest first)
+            validate_message_ordering(message_history)
+
 
 class TestStreamingMessages:
     """Test streaming message sending."""
@@ -149,6 +152,9 @@ def test_stream_message(self, client: Agentex, agent_name: str, agent_id: str):
             )
             assert len(message_history) == (i + 1) * 2  # user + agent messages
 
+            # Validate messages are in chronological order (oldest first)
+            validate_message_ordering(message_history)
+
 
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])

examples/tutorials/00_sync/020_streaming/tests/test_agent.py

@@ -19,7 +19,7 @@
 import os
 
 import pytest
-from test_utils.sync import collect_streaming_response
+from test_utils.sync import collect_streaming_response, validate_message_ordering
 
 from agentex import Agentex
 from agentex.types import TextContent, TextContentParam
@@ -100,6 +100,9 @@ def test_send_message(self, client: Agentex, agent_name: str, agent_id: str):
             )
             assert len(message_history) == (i + 1) * 2  # user + agent messages
 
+            # Validate messages are in chronological order (oldest first)
+            validate_message_ordering(message_history)
+
 
 class TestStreamingMessages:
     """Test streaming message sending."""
@@ -148,6 +151,9 @@ def test_send_stream_message(self, client: Agentex, agent_name: str, agent_id: s
             )
             assert len(message_history) == (i + 1) * 2  # user + agent messages
 
+            # Validate messages are in chronological order (oldest first)
+            validate_message_ordering(message_history)
+
 
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])

examples/tutorials/10_async/00_base/040_other_sdks/tests/test_agent.py

@@ -34,6 +34,7 @@
 from test_utils.async_utils import (
     stream_agent_response,
     send_event_and_poll_yielding,
+    validate_message_ordering,
 )
 
 from agentex import AsyncAgentex
@@ -255,6 +256,10 @@ async def test_multi_turn_conversation_with_state(self, client: AsyncAgentex, ag
         state = states[0].state
         assert state.get("turn_number") == 2
 
+        # Validate messages are in chronological order (oldest first)
+        message_history = await client.messages.list(task_id=task.id)
+        validate_message_ordering(message_history)
+
 
 class TestStreamingEvents:
     """Test streaming event sending with MCP tools and custom streaming patterns."""

examples/tutorials/10_async/10_temporal/010_agent_chat/tests/test_agent.py

@@ -33,6 +33,7 @@
 from test_utils.async_utils import (
     stream_agent_response,
     send_event_and_poll_yielding,
+    validate_message_ordering,
 )
 
 from agentex import AsyncAgentex
@@ -202,6 +203,10 @@ async def test_multi_turn_conversation(self, client: AsyncAgentex, agent_id: str
 
         assert found_response, "Did not receive final agent text response with context recall"
 
+        # Validate messages are in chronological order (oldest first)
+        message_history = await client.messages.list(task_id=task.id)
+        validate_message_ordering(message_history)
+
 
 class TestStreamingEvents:
     """Test streaming event sending with OpenAI Agents SDK and tool usage."""

examples/tutorials/10_async/10_temporal/020_state_machine/tests/test_agent.py

@@ -33,6 +33,7 @@
 from test_utils.async_utils import (
     stream_task_messages,
     send_event_and_poll_yielding,
+    validate_message_ordering,
 )
 
 from agentex import AsyncAgentex
@@ -125,6 +126,10 @@ async def test_send_event_and_poll_simple_query(self, client: AsyncAgentex, agen
         assert starting_deep_research_message, "Did not start deep research"
         assert uses_tool_requests, "Did not use tool requests"
 
+        # Validate messages are in chronological order (oldest first)
+        message_history = await client.messages.list(task_id=task.id)
+        validate_message_ordering(message_history)
+
 class TestStreamingEvents:
     """Test streaming event sending with state machine workflow."""
     @pytest.mark.asyncio
@@ -188,6 +193,10 @@ async def stream_second_turn() -> None:
         assert starting_deep_research_message, "Did not start deep research"
         assert uses_tool_requests, "Did not use tool requests"
 
+        # Validate messages are in chronological order (oldest first)
+        message_history = await client.messages.list(task_id=task.id)
+        validate_message_ordering(message_history)
+
 
 if __name__ == "__main__":
     pytest.main([__file__, "-v"])

examples/tutorials/test_utils/async_utils.py

@@ -284,3 +284,32 @@ async def stream_task_messages(
                 task_message = finished_message
         if task_message:
             yield task_message
+
+
+def validate_message_ordering(messages: list[TaskMessage]) -> None:
+    """
+    Validate that messages are in chronological order (oldest first).
+
+    This ensures the agent receives messages in the correct order for
+    multi-turn conversations.
+
+    Args:
+        messages: List of TaskMessage objects to validate
+
+    Raises:
+        AssertionError: If messages are not in chronological order
+    """
+    if len(messages) < 2:
+        return  # Nothing to validate with fewer than 2 messages
+
+    for i in range(1, len(messages)):
+        prev_msg = messages[i - 1]
+        curr_msg = messages[i]
+
+        # Validate created_at timestamps are in ascending order
+        if prev_msg.created_at is not None and curr_msg.created_at is not None:
+            assert prev_msg.created_at <= curr_msg.created_at, (
+                f"Messages are not in chronological order. "
+                f"Message {i - 1} (created_at={prev_msg.created_at}) should come before "
+                f"message {i} (created_at={curr_msg.created_at})"
+            )

examples/tutorials/test_utils/sync.py

@@ -9,6 +9,7 @@
 from typing import List, Callable, Optional, Generator
 
 from agentex.types import TextDelta, TextContent
+from agentex.types.task_message import TaskMessage
 from agentex.types.agent_rpc_result import StreamTaskMessageDone
 from agentex.types.agent_rpc_response import SendMessageResponse
 from agentex.types.task_message_update import StreamTaskMessageFull, StreamTaskMessageDelta
@@ -93,3 +94,32 @@ def collect_streaming_response(
         raise AssertionError("No content was received in the streaming response.")
 
     return aggregated_content, chunks
+
+
+def validate_message_ordering(messages: List[TaskMessage]) -> None:
+    """
+    Validate that messages are in chronological order (oldest first).
+
+    This ensures the agent receives messages in the correct order for
+    multi-turn conversations.
+
+    Args:
+        messages: List of TaskMessage objects to validate
+
+    Raises:
+        AssertionError: If messages are not in chronological order
+    """
+    if len(messages) < 2:
+        return  # Nothing to validate with fewer than 2 messages
+
+    for i in range(1, len(messages)):
+        prev_msg = messages[i - 1]
+        curr_msg = messages[i]
+
+        # Validate created_at timestamps are in ascending order
+        if prev_msg.created_at is not None and curr_msg.created_at is not None:
+            assert prev_msg.created_at <= curr_msg.created_at, (
+                f"Messages are not in chronological order. "
+                f"Message {i - 1} (created_at={prev_msg.created_at}) should come before "
+                f"message {i} (created_at={curr_msg.created_at})"
+            )