Skip to content

Commit 55b621f

Browse files
author
Shariq Hashme
committed
better exception message; handle failed requests
1 parent 47479db commit 55b621f

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

scaleapi/__init__.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
class ScaleException(Exception):
2424
def __init__(self, message, errcode):
25-
super(ScaleException, self).__init__(message)
25+
super(ScaleException, self).__init__('<Response [{}]> {}'.format(errcode, message))
2626
self.code = errcode
2727

2828

@@ -57,7 +57,12 @@ def _getrequest(self, endpoint, params={}):
5757

5858
if r.status_code == 200:
5959
return r.json()
60-
raise ScaleException(r.json()['error'], r.status_code)
60+
else:
61+
try:
62+
raise ScaleException(r.json()['error'], r.status_code)
63+
except ValueError:
64+
pass
65+
raise ScaleException(r.text, r.status_code)
6166

6267
def _postrequest(self, endpoint, payload=None):
6368
"""Makes a post request to an endpoint.
@@ -73,9 +78,12 @@ def _postrequest(self, endpoint, payload=None):
7378

7479
if r.status_code == 200:
7580
return r.json()
76-
if r.status_code == 400:
77-
raise ScaleInvalidRequest(r.json()['error'], r.status_code)
78-
raise ScaleException(r.json()['error'], r.status_code)
81+
else:
82+
try:
83+
raise ScaleException(r.json()['error'], r.status_code)
84+
except ValueError:
85+
pass
86+
raise ScaleException(r.text, r.status_code)
7987

8088
def fetch_task(self, task_id):
8189
"""Fetches a task.

0 commit comments

Comments
 (0)