Skip to content

Commit 42f364d

Browse files
committed
FileUtils: add missing architecture suffixes
These were missing in the first pass of the update to allow architecture classifiers.
1 parent 8801ace commit 42f364d

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/main/java/org/scijava/util/FileUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ public static void writeFile(final File file, final byte[] bytes)
173173
/** A regular expression to match filenames containing version information. */
174174
private final static Pattern versionPattern =
175175
Pattern
176-
.compile("(.+?)(-\\d+(\\.\\d+|\\d{7})+[a-z]?\\d?(-[A-Za-z0-9.]+?|\\.GA)*?)?((-(swing|swt|shaded|sources|javadoc|native|linux-x86_64|macosx-x86_64|windows-x86|windows-x86_64))?(\\.jar(-[a-z]*)?))");
176+
.compile("(.+?)(-\\d+(\\.\\d+|\\d{7})+[a-z]?\\d?(-[A-Za-z0-9.]+?|\\.GA)*?)?((-(swing|swt|shaded|sources|javadoc|native|linux-x86|linux-x86_64|macosx-x86_64|windows-x86|windows-x86_64|android-arm|android-x86))?(\\.jar(-[a-z]*)?))");
177177

178178
public static String stripFilenameVersion(final String filename) {
179179
final Matcher matcher = versionPattern.matcher(filename);

src/test/java/org/scijava/util/FileUtilsTest.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import static org.junit.Assert.assertArrayEquals;
3535
import static org.junit.Assert.assertEquals;
3636
import static org.junit.Assert.assertNotNull;
37-
import static org.junit.Assert.assertNotEquals;
3837
import static org.junit.Assert.assertTrue;
3938
import static org.junit.Assert.fail;
4039
import static org.scijava.test.TestUtils.createTemporaryDirectory;
@@ -292,10 +291,14 @@ public void testStripVersionFromFilename() {
292291
assertEquals(FileUtils.stripFilenameVersion("jars/miglayout-swing.jar"), FileUtils.stripFilenameVersion("jars/miglayout-3.7.3.1-swing.jar"));
293292

294293
// Test that native binary .jars don't clash with their partner hook .jar
295-
assertNotEquals("jars/ffmpeg.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-windows-x86.jar"));
296-
assertNotEquals("jars/ffmpeg.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-windows-x86_64.jar"));
297-
assertNotEquals("jars/ffmpeg.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-macosx-x86_64.jar"));
298-
assertNotEquals("jars/ffmpeg.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-linux-x86_64.jar"));
294+
assertEquals("jars/ffmpeg-windows-x86.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-windows-x86.jar"));
295+
assertEquals("jars/ffmpeg-windows-x86_64.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-windows-x86_64.jar"));
296+
assertEquals("jars/ffmpeg-macosx-x86_64.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-macosx-x86_64.jar"));
297+
assertEquals("jars/ffmpeg-linux-x86_64.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-linux-x86_64.jar"));
298+
assertEquals("jars/ffmpeg-linux-x86.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-linux-x86.jar"));
299+
assertEquals("jars/ffmpeg-android-x86.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-android-x86.jar"));
300+
assertEquals("jars/ffmpeg-android-arm.jar", FileUtils.stripFilenameVersion("jars/ffmpeg-2.6.1-0.11-android-arm.jar"));
301+
299302
}
300303

301304
@Test

0 commit comments

Comments
 (0)