Skip to content

Commit 4db4557

Browse files
committed
ConversionUtilsTest: remove unneeded helper method
1 parent 70ee8ef commit 4db4557

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

src/test/java/org/scijava/util/ConversionUtilsTest.java

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import static org.junit.Assert.assertTrue;
3939

4040
import java.util.ArrayList;
41+
import java.util.Arrays;
4142
import java.util.Collection;
4243
import java.util.HashSet;
4344
import java.util.List;
@@ -66,7 +67,7 @@ class Struct {
6667
}
6768
final Struct struct = new Struct();
6869

69-
final List<Integer> intVals = getValueList(4, 3, 7);
70+
final List<Integer> intVals = Arrays.asList(4, 3, 7);
7071
setFieldValue(struct, "intArray", intVals);
7172

7273
for (int i = 0; i < struct.intArray.length; i++) {
@@ -93,7 +94,7 @@ class Struct {
9394
final Struct struct = new Struct();
9495

9596
// Verify behavior setting an array of Objects (Doubles)
96-
final List<Double> doubleVals = getValueList(1.0, 2.0, 3.0);
97+
final List<Double> doubleVals = Arrays.asList(1.0, 2.0, 3.0);
9798
setFieldValue(struct, "doubleArray", doubleVals);
9899

99100
for (int i = 0; i < struct.doubleArray.length; i++) {
@@ -113,7 +114,7 @@ class Struct {
113114
final Struct struct = new Struct();
114115

115116
// Verify behavior setting a List of Objects (Strings)
116-
final List<String> stringVals = getValueList("ok", "still ok");
117+
final List<String> stringVals = Arrays.asList("ok", "still ok");
117118
setFieldValue(struct, "stringList", stringVals);
118119

119120
for (int i = 0; i < struct.stringList.size(); i++) {
@@ -319,7 +320,7 @@ class Struct {
319320
}
320321
final Struct struct = new Struct();
321322

322-
setFieldValue(struct, "listWrapper", getValueList(4, 8, 2));
323+
setFieldValue(struct, "listWrapper", Arrays.asList(4, 8, 2));
323324
assertNotNull(struct.listWrapper);
324325
}
325326

@@ -335,16 +336,6 @@ private void setFieldValue(final Object o, final String fieldName,
335336
ClassUtils.setValue(Types.field(o.getClass(), fieldName), o, value);
336337
}
337338

338-
/**
339-
* Convenience method to convert an array of values to a collection.
340-
*/
341-
private <T> List<T> getValueList(final T... values) {
342-
final List<T> list = new ArrayList<>();
343-
for (final T value : values)
344-
list.add(value);
345-
return list;
346-
}
347-
348339
// -- Helper Classes --
349340

350341
/**

0 commit comments

Comments
 (0)