Skip to content

Commit 75ad716

Browse files
committed
PrefService: push some methods to interface
Many of the deprecated methods do direct delegation.
1 parent 734a31c commit 75ad716

File tree

2 files changed

+57
-123
lines changed

2 files changed

+57
-123
lines changed

src/main/java/org/scijava/prefs/DefaultPrefService.java

Lines changed: 0 additions & 106 deletions
Original file line numberDiff line numberDiff line change
@@ -177,14 +177,6 @@ public void remove(final Class<?> c, final String name) {
177177

178178
// -- Deprecated methods --
179179

180-
@Deprecated
181-
@Override
182-
public void putMap(final Class<?> c, final Map<String, String> map,
183-
final String name)
184-
{
185-
put(c, name, map);
186-
}
187-
188180
@Deprecated
189181
@Override
190182
public void putMap(final Class<?> c, final Map<String, String> map) {
@@ -197,14 +189,6 @@ public Map<String, String> getMap(final Class<?> c) {
197189
return prefs(c).getMap();
198190
}
199191

200-
@Deprecated
201-
@Override
202-
public void putList(final Class<?> c, final List<String> list,
203-
final String name)
204-
{
205-
put(c, name, list);
206-
}
207-
208192
@Deprecated
209193
@Override
210194
public void putList(final Class<?> c, final List<String> list) {
@@ -223,96 +207,6 @@ public Iterable<String> getIterable(final Class<?> c, final String name) {
223207
return prefs(c).node(key(c, name)).getIterable();
224208
}
225209

226-
@Deprecated
227-
@Override
228-
public void putIterable(final Class<?> c, final Iterable<String> iterable, final String name) {
229-
put(c, name, iterable);
230-
}
231-
232-
@Deprecated
233-
@Override
234-
public String get(final String name) {
235-
return get((Class<?>) null, name);
236-
}
237-
238-
@Deprecated
239-
@Override
240-
public String get(final String name, final String defaultValue) {
241-
return get(null, name, defaultValue);
242-
}
243-
244-
@Deprecated
245-
@Override
246-
public boolean getBoolean(final String name, final boolean defaultValue) {
247-
return getBoolean(null, name, defaultValue);
248-
}
249-
250-
@Deprecated
251-
@Override
252-
public double getDouble(final String name, final double defaultValue) {
253-
return getDouble(null, name, defaultValue);
254-
}
255-
256-
@Deprecated
257-
@Override
258-
public float getFloat(final String name, final float defaultValue) {
259-
return getFloat(null, name, defaultValue);
260-
}
261-
262-
@Deprecated
263-
@Override
264-
public int getInt(final String name, final int defaultValue) {
265-
return getInt(null, name, defaultValue);
266-
}
267-
268-
@Deprecated
269-
@Override
270-
public long getLong(final String name, final long defaultValue) {
271-
return getLong(null, name, defaultValue);
272-
}
273-
274-
@Deprecated
275-
@Override
276-
public void put(final String name, final String value) {
277-
put(null, name, value);
278-
}
279-
280-
@Deprecated
281-
@Override
282-
public void put(final String name, final boolean value) {
283-
put(null, name, value);
284-
}
285-
286-
@Deprecated
287-
@Override
288-
public void put(final String name, final double value) {
289-
put(null, name, value);
290-
}
291-
292-
@Deprecated
293-
@Override
294-
public void put(final String name, final float value) {
295-
put(null, name, value);
296-
}
297-
298-
@Deprecated
299-
@Override
300-
public void put(final String name, final int value) {
301-
put(null, name, value);
302-
}
303-
304-
@Deprecated
305-
@Override
306-
public void put(final String name, final long value) {
307-
put(null, name, value);
308-
}
309-
310-
@Deprecated
311-
@Override
312-
public void clear(final String key) {
313-
clear((Class<?>) null, key);
314-
}
315-
316210
@Deprecated
317211
@Override
318212
public void clear(final String absolutePath, final String key) {

src/main/java/org/scijava/prefs/PrefService.java

Lines changed: 57 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,11 @@ default String get(final Class<?> c, final String name) {
100100
* Puts a Map into the preferences, indexed under the specified class.
101101
*/
102102
@Deprecated
103-
void putMap(Class<?> c, Map<String, String> map, String name);
103+
default void putMap(final Class<?> c, final Map<String, String> map,
104+
final String name)
105+
{
106+
put(c, name, map);
107+
}
104108

105109
/**
106110
* Puts a Map into the preferences, indexed under the given class.
@@ -116,7 +120,11 @@ default String get(final Class<?> c, final String name) {
116120
* Puts a list into the preferences, indexed under the specified class.
117121
*/
118122
@Deprecated
119-
void putList(Class<?> c, List<String> list, String name);
123+
default void putList(final Class<?> c, final List<String> list,
124+
final String name)
125+
{
126+
put(c, name, list);
127+
}
120128

121129
/** Puts a list into the preferences. */
122130
@Deprecated
@@ -133,7 +141,11 @@ default String get(final Class<?> c, final String name) {
133141
* Puts an iterable into the preferences.
134142
*/
135143
@Deprecated
136-
void putIterable(Class<?> c, Iterable<String> iterable, String name);
144+
default void putIterable(final Class<?> c, final Iterable<String> iterable,
145+
final String name)
146+
{
147+
put(c, name, iterable);
148+
}
137149

138150
/**
139151
* Gets an iterable from the preferences.
@@ -142,46 +154,74 @@ default String get(final Class<?> c, final String name) {
142154
Iterable<String> getIterable(Class<?> c, String name);
143155

144156
@Deprecated
145-
String get(String name);
157+
default String get(final String name) {
158+
return get((Class<?>) null, name);
159+
}
146160

147161
@Deprecated
148-
String get(String name, String defaultValue);
162+
default String get(final String name, final String defaultValue) {
163+
return get(null, name, defaultValue);
164+
}
149165

150166
@Deprecated
151-
boolean getBoolean(String name, boolean defaultValue);
167+
default boolean getBoolean(final String name, final boolean defaultValue) {
168+
return getBoolean(null, name, defaultValue);
169+
}
152170

153171
@Deprecated
154-
double getDouble(String name, double defaultValue);
172+
default double getDouble(final String name, final double defaultValue) {
173+
return getDouble(null, name, defaultValue);
174+
}
155175

156176
@Deprecated
157-
float getFloat(String name, float defaultValue);
177+
default float getFloat(final String name, final float defaultValue) {
178+
return getFloat(null, name, defaultValue);
179+
}
158180

159181
@Deprecated
160-
int getInt(String name, int defaultValue);
182+
default int getInt(final String name, final int defaultValue) {
183+
return getInt(null, name, defaultValue);
184+
}
161185

162186
@Deprecated
163-
long getLong(String name, long defaultValue);
187+
default long getLong(final String name, final long defaultValue) {
188+
return getLong(null, name, defaultValue);
189+
}
164190

165191
@Deprecated
166-
void put(String name, String value);
192+
default void put(final String name, final String value) {
193+
put(null, name, value);
194+
}
167195

168196
@Deprecated
169-
void put(String name, boolean value);
197+
default void put(final String name, final boolean value) {
198+
put(null, name, value);
199+
}
170200

171201
@Deprecated
172-
void put(String name, double value);
202+
default void put(final String name, final double value) {
203+
put(null, name, value);
204+
}
173205

174206
@Deprecated
175-
void put(String name, float value);
207+
default void put(final String name, final float value) {
208+
put(null, name, value);
209+
}
176210

177211
@Deprecated
178-
void put(String name, int value);
212+
default void put(final String name, final int value) {
213+
put(null, name, value);
214+
}
179215

180216
@Deprecated
181-
void put(String name, long value);
217+
default void put(final String name, final long value) {
218+
put(null, name, value);
219+
}
182220

183221
@Deprecated
184-
void clear(String key);
222+
default void clear(final String key) {
223+
clear((Class<?>) null, key);
224+
}
185225

186226
@Deprecated
187227
void clear(String absolutePath, String key);

0 commit comments

Comments
 (0)