Fix bug in ByteBankByteArray(int) ctor

The size was being initialized as non-zero.

Thanks to Gabriel Einsdorf for noticing.

Author: ctrueden

src/main/java/org/scijava/io/ByteArrayByteBank.java

@@ -58,7 +58,7 @@ public ByteArrayByteBank() {
 	 * @param initialCapacity the initial capacity of this {@link ByteBank}
 	 */
 	public ByteArrayByteBank(final int initialCapacity) {
-		this(new ByteArray(initialCapacity));
+		this(emptyByteArrayOfCapacity(initialCapacity));
 	}
 
 	/**
@@ -148,4 +148,10 @@ public long size() {
 	private void updateSize(final long newSize) {
 		size = newSize > size ? newSize : size;
 	}
+
+	private static ByteArray emptyByteArrayOfCapacity(final int capacity) {
+		final ByteArray byteArray = new ByteArray(new byte[capacity]);
+		byteArray.setSize(0);
+		return byteArray;
+	}
 }

src/test/java/org/scijava/io/ByteArrayByteBankTest.java

@@ -32,6 +32,8 @@
 
 package org.scijava.io;
 
+import org.junit.Test;
+
 /**
  * Tests {@link ByteArrayByteBank}
  *
@@ -44,4 +46,10 @@ public class ByteArrayByteBankTest extends ByteBankTest {
 	public ByteBank createByteBank() {
 		return new ByteArrayByteBank();
 	}
+
+	@Test(expected = ArrayIndexOutOfBoundsException.class)
+	public void testCreateByteBankWithCapacity() {
+		ByteArrayByteBank bank = new ByteArrayByteBank(50);
+		bank.getByte(0);
+	}
 }