ScriptService: getScript now creates the script

To avoid a proliferation of case logic and repeated creation code,
ScriptService needs public API that retrieves a cached script and
creates it if it doesn't exist.

It is not necessary to have both a lookup-only and a lookup-and-create
method: if an API consumer wants to check the existence of a ScriptInfo,
the containing Collection is accessible.

Thus getScript now simply creates the ScriptInfo if it does not already
exist.

Author: hinerm

src/main/java/org/scijava/script/DefaultScriptService.java

@@ -169,7 +169,7 @@ public Collection<ScriptInfo> getScripts() {
 
 	@Override
 	public ScriptInfo getScript(final File scriptFile) {
-		return scripts().get(scriptFile);
+		return getOrCreate(scriptFile);
 	}
 
 	@Override
@@ -455,7 +455,7 @@ private void addAliases(final HashMap<String, Class<?>> map,
 	 * are registered with the service.
 	 */
 	private ScriptInfo getOrCreate(final File file) {
-		final ScriptInfo info = getScript(file);
+		final ScriptInfo info = scripts().get(file);
 		if (info != null) return info;
 		return new ScriptInfo(getContext(), file);
 	}

src/main/java/org/scijava/script/ScriptService.java

@@ -117,8 +117,8 @@ public interface ScriptService extends SingletonService<ScriptLanguage>,
 	Collection<ScriptInfo> getScripts();
 
 	/**
-	 * Gets the {@link ScriptInfo} metadata for the script at the given file, or
-	 * null if none.
+	 * Gets the cached {@link ScriptInfo} metadata for the script at the given
+	 * file, creating it if it does not already exist.
 	 */
 	ScriptInfo getScript(File scriptFile);