ReadBufferDataHandle: fix buffer copying bug

And fix a couple of typos and a warning while we're at it.

Author: ctrueden

src/main/java/org/scijava/io/handle/ReadBufferDataHandle.java

@@ -211,9 +211,9 @@ public int read(final byte[] b, final int targetOffset, final int len)
 			// calculate local offsets
 			final int pageOffset = globalToLocalOffset(offset);
 			int localLength = pageSize - pageOffset;
-			if (read + localLength > readLength) {
-				localLength = readLength - read;
-			}
+			localLength = Math.min(localLength, readLength - read);
+			localLength = Math.min(localLength, b.length - localTargetOff);
+			if (localLength == 0) break; // we've read all we can
 
 			// copy the data
 			System.arraycopy(currentPage, pageOffset, b, localTargetOff, localLength);
@@ -281,7 +281,7 @@ private class LRUReplacementStrategy {
 		public LRUReplacementStrategy(final int numSlots) {
 			queue = new ArrayDeque<>(numSlots);
 
-			// fill the que
+			// fill the queue
 			for (int i = 0; i < numSlots; i++) {
 				queue.add(i);
 			}
@@ -295,12 +295,12 @@ public LRUReplacementStrategy(final int numSlots) {
 		 *            the id of the slot that has been accessed
 		 */
 		public void accessed(final int slotID) {
-			// put accessed element to the end of the que
+			// put accessed element to the end of the queue
 			queue.remove(slotID);
 			queue.add(slotID);
 		}
 
-		public int pickVictim(final int pageID) {
+		public int pickVictim(@SuppressWarnings("unused") final int pageID) {
 			return queue.peek();
 		}
 	}