SwingSearchBar: inline results lookup

We want to be very clear about exactly where allResults is used:
only from the EDT.

Author: ctrueden

src/main/java/org/scijava/ui/swing/search/SwingSearchBar.java

@@ -429,8 +429,14 @@ private void rebuild() {
 			// Build the new list model.
 			DefaultListModel<SearchResult> listModel = new DefaultListModel<>();
 			for (final Searcher searcher : searchers) {
-				final List<SearchResult> results = results(searcher);
-				if (results.isEmpty()) continue;
+				// Look up the results list.
+				final List<SearchResult> completeResults = //
+					allResults.get(searcher.getClass()).results();
+				if (completeResults.isEmpty()) continue;
+
+				// Limit to the top MAX_RESULTS matches only.
+				final List<SearchResult> results = completeResults.stream() //
+					.limit(MAX_RESULTS).collect(Collectors.toList());
 
 				// Add section header.
 				listModel.addElement(new SearchResultHeader(searcher.title()));
@@ -447,12 +453,6 @@ private void rebuild() {
 			else resultsList.setSelectedValue(previous, true);
 		}
 
-		private List<SearchResult> results(final Searcher searcher) {
-			assertDispatchThread();
-			return allResults.get(searcher.getClass()).results().stream().limit(
-				MAX_RESULTS).collect(Collectors.toList());
-		}
-
 		private Component icon(final String iconPath) {
 			// TODO make icon() return URL, not String.
 			if (iconPath == null || iconPath.isEmpty()) return emptyIcon();