Clear before decoding in case insensitive string comparison

Author: adazem009

src/scratch/string_functions.cpp

@@ -84,10 +84,10 @@ extern "C"
     inline int string_compare_raw_case_insensitive_inline(const char16_t *str1, size_t n1, const char16_t *str2, size_t n2)
     {
         const size_t min_len = std::min(n1, n2);
-        std::u32string cp1_str, cp2_str;
         char32_t cp1, cp2;
 
         for (size_t i = 0; i < min_len; ++i) {
+            std::u32string cp1_str, cp2_str;
             unicode::utf16::decode(str1 + i, 1, cp1_str);
             unicode::utf16::decode(str2 + i, 1, cp2_str);
 

test/scratch_classes/string_functions_test.cpp

@@ -95,6 +95,11 @@ TEST(StringFunctionsTest, CompareCaseSensitive)
     ASSERT_EQ(string_compare_case_sensitive(&str1, &str2), 0);
     ASSERT_EQ(string_compare_raw_case_sensitive(str1.data, str1.size, str2.data, str2.size), 0);
 
+    string_assign_cstring(&str1, "5.25");
+    string_assign_cstring(&str2, "5.26");
+    ASSERT_LT(string_compare_case_sensitive(&str1, &str2), 0);
+    ASSERT_LT(string_compare_raw_case_sensitive(str1.data, str1.size, str2.data, str2.size), 0);
+
     string_assign_cstring(&str1, "aBcd");
     string_assign_cstring(&str2, "abCd");
     ASSERT_LT(string_compare_case_sensitive(&str1, &str2), 0);
@@ -180,6 +185,11 @@ TEST(StringFunctionsTest, CompareCaseInsensitive)
     ASSERT_EQ(string_compare_case_insensitive(&str1, &str2), 0);
     ASSERT_EQ(string_compare_raw_case_insensitive(str1.data, str1.size, str2.data, str2.size), 0);
 
+    string_assign_cstring(&str1, "5.25");
+    string_assign_cstring(&str2, "5.26");
+    ASSERT_LT(string_compare_case_insensitive(&str1, &str2), 0);
+    ASSERT_LT(string_compare_raw_case_insensitive(str1.data, str1.size, str2.data, str2.size), 0);
+
     string_assign_cstring(&str1, "aBcd");
     string_assign_cstring(&str2, "abCd");
     ASSERT_EQ(string_compare_case_insensitive(&str1, &str2), 0);