LLVMCodeBuilder: Implement select instruction

Author: adazem009

src/dev/engine/internal/icodebuilder.h

@@ -58,6 +58,8 @@ class ICodeBuilder
         virtual CompilerValue *createExp(CompilerValue *num) = 0;
         virtual CompilerValue *createExp10(CompilerValue *num) = 0;
 
+        virtual CompilerValue *createSelect(CompilerValue *cond, CompilerValue *trueValue, CompilerValue *falseValue, Compiler::StaticType valueType) = 0;
+
         virtual void createVariableWrite(Variable *variable, CompilerValue *value) = 0;
 
         virtual void createListClear(List *list) = 0;

src/dev/engine/internal/llvm/llvmcodebuilder.cpp

@@ -446,6 +446,18 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()
                 break;
             }
 
+            case LLVMInstruction::Type::Select: {
+                assert(step.args.size() == 3);
+                const auto &arg1 = step.args[0];
+                const auto &arg2 = step.args[1];
+                const auto &arg3 = step.args[2];
+                llvm::Value *cond = castValue(arg1.second, arg1.first);
+                llvm::Value *trueValue = castValue(arg2.second, arg2.first);
+                llvm::Value *falseValue = castValue(arg3.second, arg3.first);
+                step.functionReturnReg->value = m_builder.CreateSelect(cond, trueValue, falseValue);
+                break;
+            }
+
             case LLVMInstruction::Type::WriteVariable: {
                 assert(step.args.size() == 1);
                 assert(m_variablePtrs.find(step.workVariable) != m_variablePtrs.cend());
@@ -1125,6 +1137,11 @@ CompilerValue *LLVMCodeBuilder::createExp10(CompilerValue *num)
     return createOp(LLVMInstruction::Type::Exp10, Compiler::StaticType::Number, Compiler::StaticType::Number, { num });
 }
 
+CompilerValue *LLVMCodeBuilder::createSelect(CompilerValue *cond, CompilerValue *trueValue, CompilerValue *falseValue, Compiler::StaticType valueType)
+{
+    return createOp(LLVMInstruction::Type::Select, valueType, { Compiler::StaticType::Bool, valueType, valueType }, { cond, trueValue, falseValue });
+}
+
 void LLVMCodeBuilder::createVariableWrite(Variable *variable, CompilerValue *value)
 {
     LLVMInstruction ins(LLVMInstruction::Type::WriteVariable);

src/dev/engine/internal/llvm/llvmcodebuilder.h

@@ -65,6 +65,8 @@ class LLVMCodeBuilder : public ICodeBuilder
         CompilerValue *createExp(CompilerValue *num) override;
         CompilerValue *createExp10(CompilerValue *num) override;
 
+        CompilerValue *createSelect(CompilerValue *cond, CompilerValue *trueValue, CompilerValue *falseValue, Compiler::StaticType valueType) override;
+
         void createVariableWrite(Variable *variable, CompilerValue *value) override;
 
         void createListClear(List *list) override;

src/dev/engine/internal/llvm/llvminstruction.h

@@ -40,6 +40,7 @@ struct LLVMInstruction
             Log10,
             Exp,
             Exp10,
+            Select,
             WriteVariable,
             ReadVariable,
             ClearList,

test/dev/llvm/llvmcodebuilder_test.cpp

@@ -1381,6 +1381,79 @@ TEST_F(LLVMCodeBuilderTest, WriteVariable)
     ASSERT_EQ(localVar3->value(), true);
 }
 
+TEST_F(LLVMCodeBuilderTest, Select)
+{
+    EngineMock engine;
+    Stage stage;
+    Sprite sprite;
+    sprite.setEngine(&engine);
+    EXPECT_CALL(engine, stage()).WillRepeatedly(Return(&stage));
+
+    createBuilder(&sprite, true);
+
+    // Number
+    CompilerValue *v = m_builder->addConstValue(true);
+    v = m_builder->createSelect(v, m_builder->addConstValue(5.8), m_builder->addConstValue(-17.42), Compiler::StaticType::Number);
+    m_builder->addFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { v });
+
+    v = m_builder->addConstValue(false);
+    v = m_builder->createSelect(v, m_builder->addConstValue(5.8), m_builder->addConstValue(-17.42), Compiler::StaticType::Number);
+    m_builder->addFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { v });
+
+    // Bool
+    v = m_builder->addConstValue(true);
+    v = m_builder->createSelect(v, m_builder->addConstValue(true), m_builder->addConstValue(false), Compiler::StaticType::Bool);
+    m_builder->addFunctionCall("test_print_bool", Compiler::StaticType::Void, { Compiler::StaticType::Bool }, { v });
+
+    v = m_builder->addConstValue(false);
+    v = m_builder->createSelect(v, m_builder->addConstValue(true), m_builder->addConstValue(false), Compiler::StaticType::Bool);
+    m_builder->addFunctionCall("test_print_bool", Compiler::StaticType::Void, { Compiler::StaticType::Bool }, { v });
+
+    // String
+    v = m_builder->addConstValue(true);
+    v = m_builder->createSelect(v, m_builder->addConstValue("hello"), m_builder->addConstValue("world"), Compiler::StaticType::String);
+    m_builder->addFunctionCall("test_print_string", Compiler::StaticType::Void, { Compiler::StaticType::String }, { v });
+
+    v = m_builder->addConstValue(false);
+    v = m_builder->createSelect(v, m_builder->addConstValue("hello"), m_builder->addConstValue("world"), Compiler::StaticType::String);
+    m_builder->addFunctionCall("test_print_string", Compiler::StaticType::Void, { Compiler::StaticType::String }, { v });
+
+    // Different types
+    v = m_builder->addConstValue(true);
+    v = m_builder->createSelect(v, m_builder->addConstValue("543"), m_builder->addConstValue("true"), Compiler::StaticType::Number);
+    m_builder->addFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { v });
+
+    v = m_builder->addConstValue(false);
+    v = m_builder->createSelect(v, m_builder->addConstValue("543"), m_builder->addConstValue("true"), Compiler::StaticType::Number);
+    m_builder->addFunctionCall("test_print_number", Compiler::StaticType::Void, { Compiler::StaticType::Number }, { v });
+
+    v = m_builder->addConstValue(true);
+    v = m_builder->createSelect(v, m_builder->addConstValue(1), m_builder->addConstValue("false"), Compiler::StaticType::Bool);
+    m_builder->addFunctionCall("test_print_bool", Compiler::StaticType::Void, { Compiler::StaticType::Bool }, { v });
+
+    v = m_builder->addConstValue(false);
+    v = m_builder->createSelect(v, m_builder->addConstValue(1), m_builder->addConstValue("false"), Compiler::StaticType::Bool);
+    m_builder->addFunctionCall("test_print_bool", Compiler::StaticType::Void, { Compiler::StaticType::Bool }, { v });
+
+    static const std::string expected =
+        "5.8\n"
+        "-17.42\n"
+        "1\n"
+        "0\n"
+        "hello\n"
+        "world\n"
+        "543\n"
+        "0\n"
+        "1\n"
+        "0\n";
+
+    auto code = m_builder->finalize();
+    testing::internal::CaptureStdout();
+    auto ctx = code->createExecutionContext(&sprite);
+    code->run(ctx.get());
+    ASSERT_EQ(testing::internal::GetCapturedStdout(), expected);
+}
+
 TEST_F(LLVMCodeBuilderTest, ReadVariable)
 {
     EngineMock engine;

test/mocks/codebuildermock.h

@@ -48,6 +48,8 @@ class CodeBuilderMock : public ICodeBuilder
         MOCK_METHOD(CompilerValue *, createExp, (CompilerValue *), (override));
         MOCK_METHOD(CompilerValue *, createExp10, (CompilerValue *), (override));
 
+        MOCK_METHOD(CompilerValue *, createSelect, (CompilerValue *, CompilerValue *, CompilerValue *, Compiler::StaticType), (override));
+
         MOCK_METHOD(void, createVariableWrite, (Variable *, CompilerValue *), (override));
 
         MOCK_METHOD(void, createListClear, (List *), (override));