Target: Add missing references to return values

Author: adazem009

src/scratch/target.cpp

@@ -10,7 +10,7 @@ Target::Target()
 }
 
 /*! Returns the name of the target. */
-std::string Target::name() const
+const std::string &Target::name() const
 {
     return m_name;
 }
@@ -22,7 +22,7 @@ void Target::setName(const std::string &name)
 }
 
 /*! Returns the list of variables. */
-std::vector<std::shared_ptr<Variable>> Target::variables() const
+const std::vector<std::shared_ptr<Variable>> &Target::variables() const
 {
     return m_variables;
 }
@@ -65,7 +65,7 @@ int Target::findVariableById(const std::string &id) const
 }
 
 /*! Returns the list of Scratch lists. */
-std::vector<std::shared_ptr<List>> Target::lists() const
+const std::vector<std::shared_ptr<List>> &Target::lists() const
 {
     return m_lists;
 }
@@ -108,7 +108,7 @@ int Target::findListById(const std::string &id) const
 }
 
 /*! Returns the list of blocks. */
-std::vector<std::shared_ptr<Block>> Target::blocks() const
+const std::vector<std::shared_ptr<Block>> &Target::blocks() const
 {
     return m_blocks;
 }
@@ -163,7 +163,7 @@ void Target::setCurrentCostume(int newCostume)
 }
 
 /*! Returns the list of costumes. */
-std::vector<Costume> Target::costumes() const
+const std::vector<Costume> &Target::costumes() const
 {
     return m_costumes;
 }
@@ -194,7 +194,7 @@ int Target::findCostume(const std::string &costumeName) const
 }
 
 /*! Returns the list of sounds. */
-std::vector<Sound> Target::sounds() const
+const std::vector<Sound> &Target::sounds() const
 {
     return m_sounds;
 }

src/scratch/target.h

@@ -30,22 +30,22 @@ class LIBSCRATCHCPP_EXPORT Target
         /*! Sets the target interface. */
         virtual void setInterface(IScratchTarget *newInterface) = 0;
 
-        std::string name() const;
+        const std::string &name() const;
         void setName(const std::string &name);
 
-        std::vector<std::shared_ptr<Variable>> variables() const;
+        const std::vector<std::shared_ptr<Variable>> &variables() const;
         int addVariable(std::shared_ptr<Variable> variable);
         std::shared_ptr<Variable> variableAt(int index) const;
         int findVariable(const std::string &variableName) const;
         int findVariableById(const std::string &id) const;
 
-        std::vector<std::shared_ptr<List>> lists() const;
+        const std::vector<std::shared_ptr<List>> &lists() const;
         int addList(std::shared_ptr<List> list);
         std::shared_ptr<List> listAt(int index) const;
         int findList(const std::string &listName) const;
         int findListById(const std::string &id) const;
 
-        std::vector<std::shared_ptr<Block>> blocks() const;
+        const std::vector<std::shared_ptr<Block>> &blocks() const;
         int addBlock(std::shared_ptr<Block> block);
         std::shared_ptr<Block> blockAt(int index) const;
         int findBlock(const std::string &id) const;
@@ -54,12 +54,12 @@ class LIBSCRATCHCPP_EXPORT Target
         int currentCostume() const;
         void setCurrentCostume(int newCostume);
 
-        std::vector<Costume> costumes() const;
+        const std::vector<Costume> &costumes() const;
         int addCostume(const Costume &costume);
         Costume costumeAt(int index) const;
         int findCostume(const std::string &costumeName) const;
 
-        std::vector<Sound> sounds() const;
+        const std::vector<Sound> &sounds() const;
         int addSound(const Sound &sound);
         Sound soundAt(int index) const;
         int findSound(const std::string &soundName) const;