Skip to content

Commit 1ecc9f5

Browse files
committed
Use requestRedraw() instead of breakFrame() to request redraw
1 parent 7991ee5 commit 1ecc9f5

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

src/scratch/sprite.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ std::shared_ptr<Sprite> Sprite::clone()
9494
eng->initClone(clone.get());
9595

9696
if (impl->visible)
97-
eng->breakFrame();
97+
eng->requestRedraw();
9898

9999
if (impl->iface)
100100
impl->iface->onCloned(clone.get());
@@ -158,7 +158,7 @@ void Sprite::setVisible(bool newVisible)
158158
IEngine *eng = engine();
159159

160160
if (eng)
161-
eng->breakFrame();
161+
eng->requestRedraw();
162162
}
163163

164164
if (impl->iface)
@@ -210,7 +210,7 @@ void Sprite::setSize(double newSize)
210210
IEngine *eng = engine();
211211

212212
if (eng)
213-
eng->breakFrame();
213+
eng->requestRedraw();
214214
}
215215

216216
if (impl->iface)
@@ -239,7 +239,7 @@ void Sprite::setCostumeIndex(int newCostumeIndex)
239239
IEngine *eng = engine();
240240

241241
if (eng)
242-
eng->breakFrame();
242+
eng->requestRedraw();
243243
}
244244

245245
Target::setCostumeIndex(newCostumeIndex);
@@ -265,7 +265,7 @@ void Sprite::setDirection(double newDirection)
265265
IEngine *eng = engine();
266266

267267
if (eng)
268-
eng->breakFrame();
268+
eng->requestRedraw();
269269
}
270270

271271
if (impl->iface)
@@ -317,7 +317,7 @@ void Sprite::setRotationStyle(RotationStyle newRotationStyle)
317317
IEngine *eng = engine();
318318

319319
if (eng)
320-
eng->breakFrame();
320+
eng->requestRedraw();
321321
}
322322

323323
if (impl->iface)
@@ -375,7 +375,7 @@ void Sprite::setGraphicsEffectValue(IGraphicsEffect *effect, double value)
375375
IEngine *eng = engine();
376376

377377
if (eng)
378-
eng->breakFrame();
378+
eng->requestRedraw();
379379
}
380380
}
381381

@@ -393,7 +393,7 @@ void Sprite::clearGraphicsEffects()
393393
IEngine *eng = engine();
394394

395395
if (eng)
396-
eng->breakFrame();
396+
eng->requestRedraw();
397397
}
398398
}
399399

@@ -416,6 +416,6 @@ void Sprite::setXY(double x, double y)
416416
IEngine *eng = engine();
417417

418418
if (eng)
419-
eng->breakFrame();
419+
eng->requestRedraw();
420420
}
421421
}

src/scratch/target.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ void Target::setCostumeIndex(int newCostumeIndex)
213213

214214
if (isStage()) {
215215
if (impl->engine)
216-
impl->engine->breakFrame();
216+
impl->engine->requestRedraw();
217217
}
218218
}
219219

test/scratch_classes/sprite_test.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ TEST(SpriteTest, Visible)
3535
sprite.setVisible(false);
3636
ASSERT_FALSE(sprite.visible());
3737

38-
EXPECT_CALL(engine, breakFrame());
38+
EXPECT_CALL(engine, requestRedraw());
3939
sprite.setVisible(true);
4040
ASSERT_TRUE(sprite.visible());
4141
}
@@ -123,7 +123,7 @@ TEST(SpriteTest, Clone)
123123

124124
EngineMock engine;
125125
sprite->setEngine(&engine);
126-
EXPECT_CALL(engine, breakFrame()).Times(2);
126+
EXPECT_CALL(engine, requestRedraw()).Times(2);
127127

128128
Sprite *clone1;
129129
EXPECT_CALL(engine, initClone(_)).WillOnce(SaveArg<0>(&clone1));
@@ -227,7 +227,7 @@ TEST(SpriteTest, XY)
227227

228228
EngineMock engine;
229229
sprite.setEngine(&engine);
230-
EXPECT_CALL(engine, breakFrame()).Times(18);
230+
EXPECT_CALL(engine, requestRedraw()).Times(18);
231231
EXPECT_CALL(engine, spriteFencingEnabled()).Times(4).WillRepeatedly(Return(false));
232232

233233
sprite.setX(-53.25);
@@ -400,7 +400,7 @@ TEST(SpriteTest, Size)
400400

401401
EngineMock engine;
402402
sprite.setEngine(&engine);
403-
EXPECT_CALL(engine, breakFrame()).Times(4);
403+
EXPECT_CALL(engine, requestRedraw()).Times(4);
404404

405405
sprite.setSize(63.724);
406406
ASSERT_EQ(sprite.size(), 63.724);
@@ -422,7 +422,7 @@ TEST(SpriteTest, CostumeIndex)
422422
Sprite sprite;
423423
EngineMock engine;
424424
sprite.setEngine(&engine);
425-
EXPECT_CALL(engine, breakFrame()).Times(2);
425+
EXPECT_CALL(engine, requestRedraw()).Times(2);
426426

427427
auto c1 = std::make_shared<Costume>("", "", "");
428428
auto c2 = std::make_shared<Costume>("", "", "");
@@ -443,7 +443,7 @@ TEST(SpriteTest, Direction)
443443

444444
EngineMock engine;
445445
sprite.setEngine(&engine);
446-
EXPECT_CALL(engine, breakFrame()).Times(10);
446+
EXPECT_CALL(engine, requestRedraw()).Times(10);
447447

448448
sprite.setDirection(-42.75);
449449
ASSERT_EQ(sprite.direction(), -42.75);
@@ -500,7 +500,7 @@ TEST(SpriteTest, RotationStyle)
500500

501501
EngineMock engine;
502502
sprite.setEngine(&engine);
503-
EXPECT_CALL(engine, breakFrame()).Times(8);
503+
EXPECT_CALL(engine, requestRedraw()).Times(8);
504504

505505
sprite.setRotationStyle(Sprite::RotationStyle::DoNotRotate);
506506
ASSERT_EQ(sprite.rotationStyle(), Sprite::RotationStyle::DoNotRotate);
@@ -674,7 +674,7 @@ TEST(SpriteTest, GraphicsEffects)
674674

675675
EngineMock engine;
676676
sprite.setEngine(&engine);
677-
EXPECT_CALL(engine, breakFrame()).Times(6);
677+
EXPECT_CALL(engine, requestRedraw()).Times(6);
678678

679679
sprite.addCostume(c1);
680680
sprite.addCostume(c2);

test/scratch_classes/stage_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ TEST(SpriteTest, CostumeIndex)
1717
Stage stage;
1818
EngineMock engine;
1919
stage.setEngine(&engine);
20-
EXPECT_CALL(engine, breakFrame()).Times(2);
20+
EXPECT_CALL(engine, requestRedraw()).Times(2);
2121

2222
auto c1 = std::make_shared<Costume>("", "", "");
2323
auto c2 = std::make_shared<Costume>("", "", "");

0 commit comments

Comments
 (0)